From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: JianKang Chen <chenjiankang1@huawei.com>,
mgorman@techsingularity.net, hannes@cmpxchg.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
xieyisheng1@huawei.com, guohanjun@huawei.com,
wangkefeng.wang@huawei.com
Subject: Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages
Date: Fri, 6 Apr 2018 12:58:45 -0700 [thread overview]
Message-ID: <20180406125845.72c7e116f53fc70e59302c99@linux-foundation.org> (raw)
In-Reply-To: <20180406100236.GK8286@dhcp22.suse.cz>
On Fri, 6 Apr 2018 12:02:36 +0200 Michal Hocko <mhocko@kernel.org> wrote:
> On Wed 29-11-17 17:04:46, Michal Hocko wrote:
> [...]
> > From 000bb422fe07adbfa8cd8ed953b18f48647a45d6 Mon Sep 17 00:00:00 2001
> > From: Michal Hocko <mhocko@suse.com>
> > Date: Wed, 29 Nov 2017 17:02:33 +0100
> > Subject: [PATCH] mm: drop VM_BUG_ON from __get_free_pages
> >
> > There is no real reason to blow up just because the caller doesn't know
> > that __get_free_pages cannot return highmem pages. Simply fix that up
> > silently. Even if we have some confused users such a fixup will not be
> > harmful.
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
>
> Andrew, have we reached any conclusion for this? Should I repost or drop
> it on the floor?
I actually thought we'd settled on something and merged it. hrm.
Please send a fresh patch sometime?
next prev parent reply other threads:[~2018-04-06 19:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 11:09 [PATCH resend] mm/page_alloc: fix comment is __get_free_pages JianKang Chen
2017-11-27 11:33 ` Michal Hocko
2017-11-29 16:04 ` Michal Hocko
2017-11-29 21:41 ` Andrew Morton
2017-11-30 6:53 ` Michal Hocko
2017-11-30 21:17 ` Andrew Morton
2017-12-01 7:24 ` Michal Hocko
2017-12-01 11:18 ` Michal Hocko
2017-12-14 14:06 ` Michal Hocko
2017-12-14 20:33 ` Andrew Morton
2017-12-15 9:36 ` Michal Hocko
2017-12-15 20:57 ` Andrew Morton
2017-12-16 11:52 ` Michal Hocko
2018-04-06 10:02 ` Michal Hocko
2018-04-06 19:58 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-25 7:20 JianKang Chen
2017-11-27 6:22 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406125845.72c7e116f53fc70e59302c99@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chenjiankang1@huawei.com \
--cc=guohanjun@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).