From: Baoquan He <bhe@redhat.com>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: Steven Sistare <steven.sistare@oracle.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
kirill.shutemov@linux.intel.com, Michal Hocko <mhocko@suse.com>,
Linux Memory Management List <linux-mm@kvack.org>,
dan.j.williams@intel.com, jack@suse.cz, jglisse@redhat.com,
Souptick Joarder <jrdr.linux@gmail.com>,
gregkh@linuxfoundation.org, Vlastimil Babka <vbabka@suse.cz>,
Wei Yang <richard.weiyang@gmail.com>,
dave.hansen@intel.com, rientjes@google.com, mingo@kernel.org,
osalvador@techadventures.net
Subject: Re: [PATCH v3 1/2] mm/sparse: add sparse_init_nid()
Date: Mon, 2 Jul 2018 11:42:21 +0800 [thread overview]
Message-ID: <20180702034221.GR3223@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAGM2reYBO11oaetHr0C4KgGegh9yUNZD0x4vzDW6bz8URUowcw@mail.gmail.com>
On 07/01/18 at 11:28pm, Pavel Tatashin wrote:
> > > So, on the first failure, we even stop trying to populate other
> > > sections. No more memory to do so.
> >
> > This is the thing I worry about. In old sparse_mem_maps_populate_node()
> > you can see, when not present or failed to populate, just continue. This
> > is the main difference between yours and the old code. The key logic is
> > changed here.
> >
>
> I do not see how we can succeed after the first failure. We still
> allocate from the same node:
>
> sparse_mem_map_populate() may fail only if we could not allocate large
> enough buffer vmemmap_buf_start earlier.
>
> This means that in:
> sparse_mem_map_populate()
> vmemmap_populate()
> vmemmap_populate_hugepages()
> vmemmap_alloc_block_buf() (no buffer, so call allocator)
> vmemmap_alloc_block(size, node);
> __earlyonly_bootmem_alloc(node, size, size, __pa(MAX_DMA_ADDRESS));
> memblock_virt_alloc_try_nid_raw() -> Nothing changes for
> this call to succeed. So, all consequent calls to
> sparse_mem_map_populate() in this node will fail as well.
Yes, you are right, it's improvement. Thanks.
>
> > >
> > Forgot mentioning it's the vervion in mm/sparse-vmemmap.c
>
> Sorry, I do not understand what is vervion.
Typo, 'version', should be. Sorry for that.
next prev parent reply other threads:[~2018-07-02 3:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 2:04 [PATCH v3 0/2] sparse_init rewrite Pavel Tatashin
2018-07-02 2:04 ` [PATCH v3 1/2] mm/sparse: add sparse_init_nid() Pavel Tatashin
2018-07-02 2:11 ` Baoquan He
2018-07-02 2:18 ` Pavel Tatashin
2018-07-02 2:31 ` Baoquan He
2018-07-02 2:43 ` Pavel Tatashin
2018-07-02 2:53 ` Baoquan He
2018-07-02 3:03 ` Pavel Tatashin
2018-07-02 3:14 ` Baoquan He
2018-07-02 3:17 ` Baoquan He
2018-07-02 3:28 ` Pavel Tatashin
2018-07-02 3:42 ` Baoquan He [this message]
2018-07-02 2:56 ` Baoquan He
2018-07-02 3:05 ` Pavel Tatashin
2018-07-02 19:59 ` Dave Hansen
2018-07-02 20:29 ` Pavel Tatashin
2018-07-05 13:39 ` Dave Hansen
2018-07-09 14:31 ` Pavel Tatashin
2018-07-02 2:04 ` [PATCH v3 2/2] mm/sparse: start using sparse_init_nid(), and remove old code Pavel Tatashin
2018-07-02 14:04 ` Oscar Salvador
2018-07-02 19:47 ` Dave Hansen
2018-07-02 19:54 ` Pavel Tatashin
2018-07-02 20:00 ` Dave Hansen
2018-07-02 20:12 ` Pavel Tatashin
2018-07-02 16:20 ` [PATCH v3 0/2] sparse_init rewrite Dave Hansen
2018-07-02 17:46 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702034221.GR3223@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=osalvador@techadventures.net \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=steven.sistare@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).