* [PATCH] zsmalloc: fix fall-through annotation
@ 2018-10-03 10:51 Gustavo A. R. Silva
2018-10-03 12:26 ` Sergey Senozhatsky
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-03 10:51 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta, Sergey Senozhatsky
Cc: linux-mm, linux-kernel, Gustavo A. R. Silva
Replace "fallthru" with a proper "fall through" annotation.
This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
mm/zsmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 58886d4..fd4b3a9 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -418,7 +418,7 @@ static void *zs_zpool_map(void *pool, unsigned long handle,
case ZPOOL_MM_WO:
zs_mm = ZS_MM_WO;
break;
- case ZPOOL_MM_RW: /* fallthru */
+ case ZPOOL_MM_RW: /* fall through */
default:
zs_mm = ZS_MM_RW;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] zsmalloc: fix fall-through annotation
2018-10-03 10:51 [PATCH] zsmalloc: fix fall-through annotation Gustavo A. R. Silva
@ 2018-10-03 12:26 ` Sergey Senozhatsky
2018-10-03 12:32 ` Sergey Senozhatsky
0 siblings, 1 reply; 3+ messages in thread
From: Sergey Senozhatsky @ 2018-10-03 12:26 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, linux-mm, linux-kernel
On (10/03/18 12:51), Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
Hmm, comments as annotations?
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] zsmalloc: fix fall-through annotation
2018-10-03 12:26 ` Sergey Senozhatsky
@ 2018-10-03 12:32 ` Sergey Senozhatsky
0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2018-10-03 12:32 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Andrew Morton, Gustavo A. R. Silva, Minchan Kim, Nitin Gupta,
linux-mm, linux-kernel
Oh, Cc-ing Andrew
message id: lkml.kernel.org/r/20181003105114.GA24423@embeddedor.com
---
On (10/03/18 21:26), Sergey Senozhatsky wrote:
> On (10/03/18 12:51), Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
Hmm, comments as annotations?
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-03 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-03 10:51 [PATCH] zsmalloc: fix fall-through annotation Gustavo A. R. Silva
2018-10-03 12:26 ` Sergey Senozhatsky
2018-10-03 12:32 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).