linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/slub: record final state of slub action in deactivate_slab()
@ 2018-11-07  1:31 Wei Yang
  0 siblings, 0 replies; only message in thread
From: Wei Yang @ 2018-11-07  1:31 UTC (permalink / raw)
  To: cl, akpm; +Cc: linux-mm, Wei Yang

In case __cmpxchg_double_slab() fails and (l != m), current code records
transition states of slub action.

This patch update slub action after __cmpxchg_double_slab() succeed to
record the final state.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 mm/slub.c | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 44dd1d6cfbc3..cbb1aade7858 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2136,24 +2136,14 @@ static void deactivate_slab(struct kmem_cache *s, struct page *page,
 	if (l != m) {
 
 		if (l == M_PARTIAL)
-
 			remove_partial(n, page);
-
 		else if (l == M_FULL)
-
 			remove_full(s, n, page);
 
-		if (m == M_PARTIAL) {
-
+		if (m == M_PARTIAL)
 			add_partial(n, page, tail);
-			stat(s, tail);
-
-		} else if (m == M_FULL) {
-
-			stat(s, DEACTIVATE_FULL);
+		else if (m == M_FULL)
 			add_full(s, n, page);
-
-		}
 	}
 
 	l = m;
@@ -2166,7 +2156,11 @@ static void deactivate_slab(struct kmem_cache *s, struct page *page,
 	if (lock)
 		spin_unlock(&n->list_lock);
 
-	if (m == M_FREE) {
+	if (m == M_PARTIAL)
+		stat(s, tail);
+	else if (m == M_FULL)
+		stat(s, DEACTIVATE_FULL);
+	else if (m == M_FREE) {
 		stat(s, DEACTIVATE_EMPTY);
 		discard_slab(s, page);
 		stat(s, FREE_SLAB);
-- 
2.15.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-11-07  1:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07  1:31 [PATCH] mm/slub: record final state of slub action in deactivate_slab() Wei Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).