From: Keith Busch <keith.busch@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Hansen <dave.hansen@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 6/7] acpi: Create subtable parsing infrastructure
Date: Mon, 19 Nov 2018 11:36:13 -0700 [thread overview]
Message-ID: <20181119183613.GB26707@localhost.localdomain> (raw)
In-Reply-To: <CAJZ5v0gQCpmRHdSS=xxLSx-+1xbexSFQb_ZxMvZuKUjk6+w5ww@mail.gmail.com>
On Mon, Nov 19, 2018 at 10:58:12AM +0100, Rafael J. Wysocki wrote:
> > +static unsigned long __init
> > +acpi_get_entry_length(struct acpi_subtable_entry *entry)
> > +{
> > + switch (entry->type) {
> > + case ACPI_SUBTABLE_COMMON:
> > + return entry->hdr->common.length;
> > + }
> > + WARN_ONCE(1, "invalid acpi type\n");
>
> AFAICS this does a WARN_ONCE() on information obtained from firmware.
>
> That is not a kernel problem, so generating traces in that case is not
> a good idea IMO. Moreover, users can't really do much about this in
> the majority of cases, so a pr_info() message should be sufficient.
Sure thing, I'll fix that up for the next revision.
next prev parent reply other threads:[~2018-11-19 18:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 22:49 [PATCH 1/7] node: Link memory nodes to their compute nodes Keith Busch
2018-11-14 22:49 ` [PATCH 2/7] node: Add heterogenous memory performance Keith Busch
2018-11-19 3:35 ` Anshuman Khandual
2018-11-19 15:46 ` Keith Busch
2018-11-22 13:22 ` Anshuman Khandual
2018-11-27 7:00 ` Dan Williams
2018-11-27 17:42 ` Dan Williams
2018-11-27 17:44 ` Keith Busch
2018-11-14 22:49 ` [PATCH 3/7] doc/vm: New documentation for " Keith Busch
2018-11-15 12:59 ` Jonathan Cameron
2018-12-10 16:12 ` Dan Williams
2018-11-20 13:51 ` Mike Rapoport
2018-11-20 15:31 ` Keith Busch
2018-11-14 22:49 ` [PATCH 4/7] node: Add memory caching attributes Keith Busch
2018-11-15 0:40 ` Dave Hansen
2018-11-19 4:14 ` Anshuman Khandual
2018-11-19 23:06 ` Keith Busch
2018-11-22 13:29 ` Anshuman Khandual
2018-11-26 15:14 ` Keith Busch
2018-11-26 19:06 ` Greg Kroah-Hartman
2018-11-26 19:53 ` Keith Busch
2018-11-26 19:06 ` Greg Kroah-Hartman
2018-11-14 22:49 ` [PATCH 5/7] doc/vm: New documentation for memory cache Keith Busch
2018-11-15 0:41 ` Dave Hansen
2018-11-15 13:16 ` Jonathan Cameron
2018-11-20 13:53 ` Mike Rapoport
2018-11-14 22:49 ` [PATCH 6/7] acpi: Create subtable parsing infrastructure Keith Busch
2018-11-19 9:58 ` Rafael J. Wysocki
2018-11-19 18:36 ` Keith Busch [this message]
2018-11-14 22:49 ` [PATCH 7/7] acpi/hmat: Parse and report heterogeneous memory Keith Busch
2018-11-15 13:57 ` [PATCH 1/7] node: Link memory nodes to their compute nodes Matthew Wilcox
2018-11-15 14:59 ` Keith Busch
2018-11-15 17:50 ` Dan Williams
2018-11-19 3:04 ` Anshuman Khandual
2018-11-15 20:36 ` Matthew Wilcox
2018-11-16 18:32 ` Keith Busch
2018-11-19 3:15 ` Anshuman Khandual
2018-11-19 15:49 ` Keith Busch
2018-12-04 15:43 ` Aneesh Kumar K.V
2018-12-04 16:54 ` Keith Busch
2018-11-16 22:55 ` Dan Williams
2018-11-19 2:52 ` Anshuman Khandual
2018-11-19 2:46 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119183613.GB26707@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).