Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Jan Kara]

On Tue 19-02-19 14:17:09, Meelis Roos wrote:
> > > > > The result of the bisection is
> > > > > [88dbcbb3a4847f5e6dfeae952d3105497700c128] blkdev: avoid migration stalls for blkdev pages
> > > > > 
> > > > > Is that result relevant for the problem or should I continue bisecting between 4.20.0 and the so far first bad commit?
> > > > 
> > > > Can you try reverting the commit and see if it makes the problem go away?
> > > 
> > > Tried reverting it on top of 5.0.0-rc6-00153-g5ded5871030e and it seems
> > > to make the kernel work - emerge --sync succeeded.
> There is more to it.
> 
> After running 5.0.0-rc6-00153-g5ded5871030e-dirty (with the revert of
> that patch) successfully for Gentoo update, I upgraded the kernel to
> 5.0.0-rc7-00011-gb5372fe5dc84-dirty (todays git + revert of this patch)
> and it broke on rsync again:
> 
> RepoStorageException: command exited with status -6: rsync -a --link-dest /usr/portage --exclude=/distfiles --exclude=/local --exclude=/lost+found --exclude=/packages --exclude /.tmp-unverified-download-quarantine /usr/portage/ /usr/portage/.tmp-unverified-download-quarantine/
> 
> Nothing in dmesg.
> 
> This means the real root reason is somewhere deeper and reverting this
> commit just made it less likely to happen.

Thanks for information. Yeah, that makes somewhat more sense. Can you ever
see the failure if you disable CONFIG_TRANSPARENT_HUGEPAGE? Because your
findings still seem to indicate that there' some problem with page
migration and Alpha (added MM list to CC).

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Meelis Roos]

> Thanks for information. Yeah, that makes somewhat more sense. Can you ever
> see the failure if you disable CONFIG_TRANSPARENT_HUGEPAGE?
HAVE_ARCH_TRANSPARENT_HUGEPAGE [=n]

Seems there is no THP on alpha.

> Because your
> findings still seem to indicate that there' some problem with page
> migration and Alpha (added MM list to CC).

But my kernel config had memory compaction (that turned on page migration) and
bounce buffers. I do not remember why I found them necessary but I will try
without them.

-- 
Meelis Roos <mroos@linux.ee>

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Matthew Wilcox]

On Tue, Feb 19, 2019 at 02:20:26PM +0100, Jan Kara wrote:
> Thanks for information. Yeah, that makes somewhat more sense. Can you ever
> see the failure if you disable CONFIG_TRANSPARENT_HUGEPAGE? Because your
> findings still seem to indicate that there' some problem with page
> migration and Alpha (added MM list to CC).

Could
https://lore.kernel.org/linux-mm/20190219123212.29838-1-larper@axis.com/T/#u
be relevant?

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Meelis Roos]

> Could
> https://lore.kernel.org/linux-mm/20190219123212.29838-1-larper@axis.com/T/#u
> be relevant?

Tried it, still broken.

I wrote:

> But my kernel config had memory compaction (that turned on page migration) and
> bounce buffers. I do not remember why I found them necessary but I will try
> without them. 

First, I found out that both the problematic alphas had memory compaction and
page migration and bounce buffers turned on, and working alphas had them off.

Next, turing off these options makes the problematic alphas work.

-- 
Meelis Roos <mroos@linux.ee>

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Jan Kara]

On Wed 20-02-19 08:31:05, Meelis Roos wrote:
> > Could
> > https://lore.kernel.org/linux-mm/20190219123212.29838-1-larper@axis.com/T/#u
> > be relevant?
> 
> Tried it, still broken.

OK, I didn't put too much hope into this patch as you see filesystem
metadata corruption so icache/dcache coherency issues seemed unlikely.
Still good that you've tried so that we are sure.

> I wrote:
> 
> > But my kernel config had memory compaction (that turned on page migration) and
> > bounce buffers. I do not remember why I found them necessary but I will try
> > without them.
> 
> First, I found out that both the problematic alphas had memory compaction and
> page migration and bounce buffers turned on, and working alphas had them off.
> 
> Next, turing off these options makes the problematic alphas work.

OK, thanks for testing! Can you narrow down whether the problem is due to
CONFIG_BOUNCE or CONFIG_MIGRATION + CONFIG_COMPACTION? These are two
completely different things so knowing where to look will help. Thanks!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Meelis Roos]

>> First, I found out that both the problematic alphas had memory compaction and
>> page migration and bounce buffers turned on, and working alphas had them off.
>>
>> Next, turing off these options makes the problematic alphas work.
> 
> OK, thanks for testing! Can you narrow down whether the problem is due to
> CONFIG_BOUNCE or CONFIG_MIGRATION + CONFIG_COMPACTION? These are two
> completely different things so knowing where to look will help. Thanks!

Tested both.

Just CONFIG_MIGRATION + CONFIG_COMPACTION breaks the alpha.
Just CONFIG_BOUNCE has no effect in 5 tries.

-- 
Meelis Roos

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Jan Kara]

On Thu 21-02-19 01:23:50, Meelis Roos wrote:
> > > First, I found out that both the problematic alphas had memory compaction and
> > > page migration and bounce buffers turned on, and working alphas had them off.
> > > 
> > > Next, turing off these options makes the problematic alphas work.
> > 
> > OK, thanks for testing! Can you narrow down whether the problem is due to
> > CONFIG_BOUNCE or CONFIG_MIGRATION + CONFIG_COMPACTION? These are two
> > completely different things so knowing where to look will help. Thanks!
> 
> Tested both.
> 
> Just CONFIG_MIGRATION + CONFIG_COMPACTION breaks the alpha.
> Just CONFIG_BOUNCE has no effect in 5 tries.

OK, so page migration is problematic. Thanks for confirmation!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[matoro]

Hello all, I know this is quite an old thread.  I recently acquired some 
alpha hardware and have run into this exact same problem on the latest 
stable kernel (5.18 and 5.19).  CONFIG_COMPACTION seems to be totally 
broken and causes userspace to be extremely unstable - random segfaults, 
corruption of glibc data structures, gcc ICEs etc etc - seems most 
noticable during tasks with heavy I/O load.

My hardware is a DS15 (Titan), so only slightly newer than the Tsunamis 
mentioned earlier.  The problem is greatly exacerbated when using a 
machine-optimized kernel (CONFIG_ALPHA_TITAN) over one with 
CONFIG_ALPHA_GENERIC.  But it still doesn't go away on a generic kernel, 
just pops up less often, usually very I/O heavy tasks like checking out 
a tag in the kernel repo.

However all of this seems to be dependent on CONFIG_COMPACTION.  With 
this toggled off all problems disappear, regardless of other options.  I 
tried reverting the commit 88dbcbb3a4847f5e6dfeae952d3105497700c128 
mentioned earlier in the thread (the structure has moved to a different 
file but was otherwise the same), but it unfortunately did not make a 
difference.

Since this doesn't seem to have a known cause or an easy fix, would it 
be reasonable to just add a Kconfig dep to disable it automatically on 
alpha?

Thank you!

-------- Original Message --------
Subject: Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28
Date: 2019-02-21 08:29
 From: Jan Kara <jack@suse.cz>
To: Meelis Roos <mroos@linux.ee>

On Thu 21-02-19 01:23:50, Meelis Roos wrote:
> > > First, I found out that both the problematic alphas had memory compaction and
> > > page migration and bounce buffers turned on, and working alphas had them off.
> > >
> > > Next, turing off these options makes the problematic alphas work.
> >
> > OK, thanks for testing! Can you narrow down whether the problem is due to
> > CONFIG_BOUNCE or CONFIG_MIGRATION + CONFIG_COMPACTION? These are two
> > completely different things so knowing where to look will help. Thanks!
> 
> Tested both.
> 
> Just CONFIG_MIGRATION + CONFIG_COMPACTION breaks the alpha.
> Just CONFIG_BOUNCE has no effect in 5 tries.

OK, so page migration is problematic. Thanks for confirmation!

								Honza

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Jan Kara]

On Thu 25-08-22 11:05:48, matoro wrote:
> Hello all, I know this is quite an old thread.  I recently acquired some
> alpha hardware and have run into this exact same problem on the latest
> stable kernel (5.18 and 5.19).  CONFIG_COMPACTION seems to be totally broken
> and causes userspace to be extremely unstable - random segfaults, corruption
> of glibc data structures, gcc ICEs etc etc - seems most noticable during
> tasks with heavy I/O load.
> 
> My hardware is a DS15 (Titan), so only slightly newer than the Tsunamis
> mentioned earlier.  The problem is greatly exacerbated when using a
> machine-optimized kernel (CONFIG_ALPHA_TITAN) over one with
> CONFIG_ALPHA_GENERIC.  But it still doesn't go away on a generic kernel,
> just pops up less often, usually very I/O heavy tasks like checking out a
> tag in the kernel repo.
> 
> However all of this seems to be dependent on CONFIG_COMPACTION.  With this
> toggled off all problems disappear, regardless of other options.  I tried
> reverting the commit 88dbcbb3a4847f5e6dfeae952d3105497700c128 mentioned
> earlier in the thread (the structure has moved to a different file but was
> otherwise the same), but it unfortunately did not make a difference.
> 
> Since this doesn't seem to have a known cause or an easy fix, would it be
> reasonable to just add a Kconfig dep to disable it automatically on alpha?

Thanks for report. I guess this just confirms that migration of pagecache
pages is somehow broken on Alpha. Maybe we are missing to flush some cache
specific for Alpha? Or maybe the page migration code is not safe wrt the
peculiar memory ordering Alpha has... I think this will need someone with
Alpha HW and willingness to dive into MM internals to debug this. Added
Vlasta to CC mostly for awareness and in case it rings some bells :).

								Honza

> -------- Original Message --------
> Subject: Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28
> Date: 2019-02-21 08:29
> From: Jan Kara <jack@suse.cz>
> To: Meelis Roos <mroos@linux.ee>
> 
> On Thu 21-02-19 01:23:50, Meelis Roos wrote:
> > > > First, I found out that both the problematic alphas had memory compaction and
> > > > page migration and bounce buffers turned on, and working alphas had them off.
> > > >
> > > > Next, turing off these options makes the problematic alphas work.
> > >
> > > OK, thanks for testing! Can you narrow down whether the problem is due to
> > > CONFIG_BOUNCE or CONFIG_MIGRATION + CONFIG_COMPACTION? These are two
> > > completely different things so knowing where to look will help. Thanks!
> > 
> > Tested both.
> > 
> > Just CONFIG_MIGRATION + CONFIG_COMPACTION breaks the alpha.
> > Just CONFIG_BOUNCE has no effect in 5 tries.
> 
> OK, so page migration is problematic. Thanks for confirmation!
> 
> 								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[Vlastimil Babka]

On 8/26/22 12:55, Jan Kara wrote:
> On Thu 25-08-22 11:05:48, matoro wrote:
>> Hello all, I know this is quite an old thread.  I recently acquired some
>> alpha hardware and have run into this exact same problem on the latest
>> stable kernel (5.18 and 5.19).  CONFIG_COMPACTION seems to be totally broken
>> and causes userspace to be extremely unstable - random segfaults, corruption
>> of glibc data structures, gcc ICEs etc etc - seems most noticable during
>> tasks with heavy I/O load.
>> 
>> My hardware is a DS15 (Titan), so only slightly newer than the Tsunamis
>> mentioned earlier.  The problem is greatly exacerbated when using a
>> machine-optimized kernel (CONFIG_ALPHA_TITAN) over one with
>> CONFIG_ALPHA_GENERIC.  But it still doesn't go away on a generic kernel,
>> just pops up less often, usually very I/O heavy tasks like checking out a
>> tag in the kernel repo.
>> 
>> However all of this seems to be dependent on CONFIG_COMPACTION.  With this
>> toggled off all problems disappear, regardless of other options.  I tried
>> reverting the commit 88dbcbb3a4847f5e6dfeae952d3105497700c128 mentioned
>> earlier in the thread (the structure has moved to a different file but was
>> otherwise the same), but it unfortunately did not make a difference.
>> 
>> Since this doesn't seem to have a known cause or an easy fix, would it be
>> reasonable to just add a Kconfig dep to disable it automatically on alpha?
> 
> Thanks for report. I guess this just confirms that migration of pagecache
> pages is somehow broken on Alpha. Maybe we are missing to flush some cache
> specific for Alpha? Or maybe the page migration code is not safe wrt the
> peculiar memory ordering Alpha has... I think this will need someone with
> Alpha HW and willingness to dive into MM internals to debug this. Added
> Vlasta to CC mostly for awareness and in case it rings some bells :).

Hi, doesn't ring any bells unfortunately. Does corruption also happen when
mmapping a file and applying mbind() with MPOL_MF_MOVE or migrate_pages()?
That should allow more controlled migration experimens than through
compaction. But that would also need a NUMA machine or a fakenuma support,
dunno if alpha has that?

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

[matoro]

At least according to the docs I see, fakenuma is x86-specific.  There 
are multi-socket machines, but the one I have is single-socket 
single-core.

I can provide access to this machine to play around with it though!  
Either simple shell access or serial access if some kernel poking is 
needed.

Would that be helpful or is a NUMA system going to be required for 
debugging?

-------- Original Message --------
Subject: Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28
Date: 2022-08-26 07:04
 From: Vlastimil Babka <vbabka@suse.cz>
To: Jan Kara <jack@suse.cz>, matoro 
<matoro_mailinglist_kernel@matoro.tk>

On 8/26/22 12:55, Jan Kara wrote:
> On Thu 25-08-22 11:05:48, matoro wrote:
>> Hello all, I know this is quite an old thread.  I recently acquired 
>> some
>> alpha hardware and have run into this exact same problem on the latest
>> stable kernel (5.18 and 5.19).  CONFIG_COMPACTION seems to be totally 
>> broken
>> and causes userspace to be extremely unstable - random segfaults, 
>> corruption
>> of glibc data structures, gcc ICEs etc etc - seems most noticable 
>> during
>> tasks with heavy I/O load.
>> 
>> My hardware is a DS15 (Titan), so only slightly newer than the 
>> Tsunamis
>> mentioned earlier.  The problem is greatly exacerbated when using a
>> machine-optimized kernel (CONFIG_ALPHA_TITAN) over one with
>> CONFIG_ALPHA_GENERIC.  But it still doesn't go away on a generic 
>> kernel,
>> just pops up less often, usually very I/O heavy tasks like checking 
>> out a
>> tag in the kernel repo.
>> 
>> However all of this seems to be dependent on CONFIG_COMPACTION.  With 
>> this
>> toggled off all problems disappear, regardless of other options.  I 
>> tried
>> reverting the commit 88dbcbb3a4847f5e6dfeae952d3105497700c128 
>> mentioned
>> earlier in the thread (the structure has moved to a different file but 
>> was
>> otherwise the same), but it unfortunately did not make a difference.
>> 
>> Since this doesn't seem to have a known cause or an easy fix, would it 
>> be
>> reasonable to just add a Kconfig dep to disable it automatically on 
>> alpha?
> 
> Thanks for report. I guess this just confirms that migration of 
> pagecache
> pages is somehow broken on Alpha. Maybe we are missing to flush some 
> cache
> specific for Alpha? Or maybe the page migration code is not safe wrt 
> the
> peculiar memory ordering Alpha has... I think this will need someone 
> with
> Alpha HW and willingness to dive into MM internals to debug this. Added
> Vlasta to CC mostly for awareness and in case it rings some bells :).

Hi, doesn't ring any bells unfortunately. Does corruption also happen 
when
mmapping a file and applying mbind() with MPOL_MF_MOVE or 
migrate_pages()?
That should allow more controlled migration experimens than through
compaction. But that would also need a NUMA machine or a fakenuma 
support,
dunno if alpha has that?