From: Hillf Danton <hdanton@sina.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Masoud Sharbiani <msharbiani@apple.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: Possible mem cgroup bug in kernels between 4.18.0 and 5.3-rc1.
Date: Fri, 2 Aug 2019 20:10:58 +0800 [thread overview]
Message-ID: <20190802121059.13192-1-hdanton@sina.com> (raw)
On Fri, 2 Aug 2019 16:18:40 +0800 Michal Hocko wrote:
>
> [Hillf, your email client or workflow mangles emails. In this case you
> are seem to be reusing the message id from the email you are replying to
> which confuses my email client to assume your email is a duplicate.]
[Hi Michal, I sent the previous mail with
Message-id: <7EE30F16-A90B-47DC-A065-3C21881CD1CC@apple.com>
using git send-email after quitting vi. That tag is removed from this
message and get me informed if it makes your mail client happy.]
>
> Huh, what? You are effectively saying that we should fail the charge
> when the requested nr_pages would fit in. This doesn't make much sense
> to me. What are you trying to achive here?
The report looks like the result of a tight loop.
I want to break it and make the end result of do_page_fault unsuccessful
if nr_retries rounds of page reclaiming fail to get work done. What made
me a bit over stretched is how to determine if the chargee is a memhog
in memcg's vocabulary.
What I prefer here is that do_page_fault succeeds, even if the chargee
exhausts its memory quota/budget granted, as long as more than nr_pages
can be reclaimed _within_ nr_retries rounds. IOW the deadline for memhog
is nr_retries, and no more.
Thanks
Hillf
next reply other threads:[~2019-08-02 12:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 12:10 Hillf Danton [this message]
2019-08-02 13:40 ` Possible mem cgroup bug in kernels between 4.18.0 and 5.3-rc1 Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2019-08-03 5:45 Hillf Danton
2019-08-01 18:04 Masoud Sharbiani
2019-08-01 18:19 ` Greg KH
2019-08-01 22:26 ` Masoud Sharbiani
2019-08-02 1:08 ` Masoud Sharbiani
2019-08-02 8:08 ` Hillf Danton
2019-08-02 8:18 ` Michal Hocko
2019-08-02 7:40 ` Michal Hocko
2019-08-02 14:18 ` Masoud Sharbiani
2019-08-02 14:41 ` Michal Hocko
2019-08-02 18:00 ` Masoud Sharbiani
2019-08-02 19:14 ` Michal Hocko
2019-08-02 23:28 ` Masoud Sharbiani
2019-08-03 2:36 ` Tetsuo Handa
2019-08-03 15:51 ` Tetsuo Handa
2019-08-03 17:41 ` Masoud Sharbiani
2019-08-03 18:24 ` Masoud Sharbiani
2019-08-05 8:42 ` Michal Hocko
2019-08-05 11:36 ` Tetsuo Handa
2019-08-05 11:44 ` Michal Hocko
2019-08-05 14:00 ` Tetsuo Handa
2019-08-05 14:26 ` Michal Hocko
2019-08-06 10:26 ` Tetsuo Handa
2019-08-06 10:50 ` Michal Hocko
2019-08-05 8:18 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802121059.13192-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=cgroups@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=msharbiani@apple.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).