From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: nitesh@redhat.com, kvm@vger.kernel.org, david@redhat.com,
dave.hansen@intel.com, linux-kernel@vger.kernel.org,
willy@infradead.org, mhocko@kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, virtio-dev@lists.oasis-open.org,
osalvador@suse.de, yang.zhang.wz@gmail.com, pagupta@redhat.com,
riel@surriel.com, konrad.wilk@oracle.com, lcapitulino@redhat.com,
wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com
Subject: Re: [PATCH v7 5/6] virtio-balloon: Pull page poisoning config out of free page hinting
Date: Wed, 4 Sep 2019 15:28:41 -0400 [thread overview]
Message-ID: <20190904152244-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190904151055.13848.27351.stgit@localhost.localdomain>
On Wed, Sep 04, 2019 at 08:10:55AM -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>
> Currently the page poisoning setting wasn't being enabled unless free page
> hinting was enabled. However we will need the page poisoning tracking logic
> as well for unused page reporting. As such pull it out and make it a
> separate bit of config in the probe function.
>
> In addition we can actually wrap the code in a check for NO_SANITY. If we
> don't care what is actually in the page we can just default to 0 and leave
> it there.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
> drivers/virtio/virtio_balloon.c | 19 +++++++++++++------
> mm/page_reporting.c | 4 ++++
> 2 files changed, 17 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 226fbb995fb0..2c19457ab573 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -842,7 +842,6 @@ static int virtio_balloon_register_shrinker(struct virtio_balloon *vb)
> static int virtballoon_probe(struct virtio_device *vdev)
> {
> struct virtio_balloon *vb;
> - __u32 poison_val;
> int err;
>
> if (!vdev->config->get) {
> @@ -909,11 +908,19 @@ static int virtballoon_probe(struct virtio_device *vdev)
> VIRTIO_BALLOON_CMD_ID_STOP);
> spin_lock_init(&vb->free_page_list_lock);
> INIT_LIST_HEAD(&vb->free_page_list);
> - if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) {
> - memset(&poison_val, PAGE_POISON, sizeof(poison_val));
> - virtio_cwrite(vb->vdev, struct virtio_balloon_config,
> - poison_val, &poison_val);
> - }
> + }
> + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) {
> + __u32 poison_val = 0;
> +
> +#if !defined(CONFIG_PAGE_POISONING_NO_SANITY)
> + /*
> + * Let hypervisor know that we are expecting a specific
> + * value to be written back in unused pages.
> + */
> + memset(&poison_val, PAGE_POISON, sizeof(poison_val));
> +#endif
> + virtio_cwrite(vb->vdev, struct virtio_balloon_config,
> + poison_val, &poison_val);
> }
> /*
> * We continue to use VIRTIO_BALLOON_F_DEFLATE_ON_OOM to decide if a
I'm a bit confused by this part. Should we not just clear
VIRTIO_BALLOON_F_PAGE_POISON completely?
In my mind the value written should be what guest puts in
free pages - and possibly what it expects to find there later.
If it doesn't expect anything there then it makes sense
to clear VIRTIO_BALLOON_F_PAGE_POISON so that host does
not try to put the poison value there.
But I think that it does not make sense to lie to host about the poison
value - I think that if we do send poison value to
host it's reasonable for host to expect free pages
have that value - and even possibly to validate that.
So I think that the hack belongs in virtballoon_validate,
near the page_poisoning_enabled check.
> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index 5006b08d5eec..35c0fe4c4471 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -299,6 +299,10 @@ int page_reporting_startup(struct page_reporting_dev_info *phdev)
> struct zone *zone;
> int err = 0;
>
> + /* No point in enabling this if it cannot handle any pages */
> + if (!phdev->capacity)
> + return -EINVAL;
> +
> mutex_lock(&page_reporting_mutex);
>
> /* nothing to do if already in use */
next prev parent reply other threads:[~2019-09-04 19:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 15:10 [PATCH v7 0/6] mm / virtio: Provide support for unused page reporting Alexander Duyck
2019-09-04 15:10 ` [PATCH v7 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-09-04 21:10 ` Dan Williams
2019-09-04 15:10 ` [PATCH v7 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-09-04 21:11 ` Dan Williams
2019-09-04 15:10 ` [PATCH v7 3/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-09-06 9:51 ` David Hildenbrand
2019-09-06 10:08 ` Pankaj Gupta
2019-09-04 15:10 ` [PATCH v7 4/6] mm: Introduce Reported pages Alexander Duyck
2019-09-04 15:10 ` [PATCH v7 5/6] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-09-04 19:28 ` Michael S. Tsirkin [this message]
2019-09-04 20:32 ` [virtio-dev] " Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 6/6] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-09-04 19:17 ` Michael S. Tsirkin
2019-09-04 20:15 ` Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 QEMU 1/3] virtio-ballon: Implement support for page poison tracking feature Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 QEMU 2/3] virtio-balloon: Add bit to notify guest of unused page reporting Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 QEMU 3/3] virtio-balloon: Provide a interface for " Alexander Duyck
2019-09-04 19:20 ` [PATCH v7 0/6] mm / virtio: Provide support " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904152244-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=nitesh@redhat.com \
--cc=osalvador@suse.de \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
--cc=willy@infradead.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).