From: Dan Williams <dan.j.williams@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: nitesh@redhat.com, KVM list <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Hildenbrand <david@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>, Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
virtio-dev@lists.oasis-open.org,
Oscar Salvador <osalvador@suse.de>,
yang.zhang.wz@gmail.com, Pankaj Gupta <pagupta@redhat.com>,
Rik van Riel <riel@surriel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
lcapitulino@redhat.com, "Wang, Wei W" <wei.w.wang@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>
Subject: Re: [PATCH v7 1/6] mm: Adjust shuffle code to allow for future coalescing
Date: Wed, 4 Sep 2019 14:10:17 -0700 [thread overview]
Message-ID: <CAPcyv4jZVoztoRA7hEq5xzbwg0QJ+UVASuk5XQmB5KHQrvAmfA@mail.gmail.com> (raw)
In-Reply-To: <20190904151030.13848.25822.stgit@localhost.localdomain>
On Wed, Sep 4, 2019 at 8:10 AM Alexander Duyck
<alexander.duyck@gmail.com> wrote:
>
> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>
> Move the head/tail adding logic out of the shuffle code and into the
> __free_one_page function since ultimately that is where it is really
> needed anyway. By doing this we should be able to reduce the overhead
> and can consolidate all of the list addition bits in one spot.
>
> While changing out the code I also opted to go for a bit more thread safe
> approach to getting the boolean value. This way we can avoid possible cache
> line bouncing of the batched entropy between CPUs.
The original version of this patch just did the movement, but now the
patch also does the percpu optimization. At this point it warrants
being split into a "move" patch and then "rework". Otherwise the bulk
of the patch is not really well described by the patch title. With the
split there's a commit id for each of the performance improvement
claims.
Other than that the percpu logic changes look good to me.
next prev parent reply other threads:[~2019-09-04 21:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 15:10 [PATCH v7 0/6] mm / virtio: Provide support for unused page reporting Alexander Duyck
2019-09-04 15:10 ` [PATCH v7 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-09-04 21:10 ` Dan Williams [this message]
2019-09-04 15:10 ` [PATCH v7 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-09-04 21:11 ` Dan Williams
2019-09-04 15:10 ` [PATCH v7 3/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-09-06 9:51 ` David Hildenbrand
2019-09-06 10:08 ` Pankaj Gupta
2019-09-04 15:10 ` [PATCH v7 4/6] mm: Introduce Reported pages Alexander Duyck
2019-09-04 15:10 ` [PATCH v7 5/6] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-09-04 19:28 ` Michael S. Tsirkin
2019-09-04 20:32 ` [virtio-dev] " Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 6/6] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-09-04 19:17 ` Michael S. Tsirkin
2019-09-04 20:15 ` Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 QEMU 1/3] virtio-ballon: Implement support for page poison tracking feature Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 QEMU 2/3] virtio-balloon: Add bit to notify guest of unused page reporting Alexander Duyck
2019-09-04 15:11 ` [PATCH v7 QEMU 3/3] virtio-balloon: Provide a interface for " Alexander Duyck
2019-09-04 19:20 ` [PATCH v7 0/6] mm / virtio: Provide support " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jZVoztoRA7hEq5xzbwg0QJ+UVASuk5XQmB5KHQrvAmfA@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=nitesh@redhat.com \
--cc=osalvador@suse.de \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
--cc=willy@infradead.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).