From: Andrew Morton <akpm@linux-foundation.org>
To: zhong jiang <zhongjiang@huawei.com>
Cc: John Hubbard <jhubbard@nvidia.com>,
Vlastimil Babka <vbabka@suse.cz>, <mhocko@kernel.org>,
<anshuman.khandual@arm.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH] mm: Unsigned 'nr_pages' always larger than zero
Date: Wed, 16 Oct 2019 17:49:55 -0700 [thread overview]
Message-ID: <20191016174955.300d5fd4968537151d3ad43f@linux-foundation.org> (raw)
In-Reply-To: <5DA6DDE0.6000804@huawei.com>
On Wed, 16 Oct 2019 17:07:44 +0800 zhong jiang <zhongjiang@huawei.com> wrote:
> >> --- a/mm/gup.c~a
> >> +++ a/mm/gup.c
> >> @@ -1450,6 +1450,7 @@ static long check_and_migrate_cma_pages(
> >> bool drain_allow = true;
> >> bool migrate_allow = true;
> >> LIST_HEAD(cma_page_list);
> >> + long ret;
> >> check_again:
> >> for (i = 0; i < nr_pages;) {
> >> @@ -1511,17 +1512,18 @@ check_again:
> >> * again migrating any new CMA pages which we failed to isolate
> >> * earlier.
> >> */
> >> - nr_pages = __get_user_pages_locked(tsk, mm, start, nr_pages,
> >> + ret = __get_user_pages_locked(tsk, mm, start, nr_pages,
> >> pages, vmas, NULL,
> >> gup_flags);
> >> - if ((nr_pages > 0) && migrate_allow) {
> >> + nr_pages = ret;
> >> + if (ret > 0 && migrate_allow) {
> >> drain_allow = true;
> >> goto check_again;
> >> }
> >> }
> >> - return nr_pages;
> >> + return ret;
> >> }
> >> #else
> >> static long check_and_migrate_cma_pages(struct task_struct *tsk,
> >>
> >
> > +1 for this approach, please.
> >
> >
> > thanks,
> Hi, Andrew
>
> I didn't see the fix for the issue in the upstream. Your proposal should be
> appiled to upstream. Could you appiled the patch or repost by me ?
Forgotten about it ;) Please send a patch sometime?
next prev parent reply other threads:[~2019-10-17 0:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 10:26 [PATCH] mm: Unsigned 'nr_pages' always larger than zero zhong jiang
2019-09-04 11:24 ` Vlastimil Babka
2019-09-04 18:25 ` Weiny, Ira
2019-09-04 18:39 ` Matthew Wilcox
2019-09-04 18:48 ` Andrew Morton
2019-09-04 20:20 ` Weiny, Ira
2019-09-04 20:40 ` Vlastimil Babka
2019-09-05 6:18 ` zhong jiang
2019-09-05 7:19 ` Vlastimil Babka
2019-09-05 6:19 ` John Hubbard
2019-10-16 9:07 ` zhong jiang
2019-10-17 0:49 ` Andrew Morton [this message]
2019-10-17 1:38 ` zhong jiang
2019-09-04 19:01 ` Andrew Morton
2019-09-04 20:44 ` Vlastimil Babka
2019-09-05 2:05 ` zhong jiang
2019-10-17 3:19 zhong jiang
2019-10-17 18:01 ` Ira Weiny
2019-10-18 2:01 ` zhong jiang
2019-10-17 20:42 ` John Hubbard
2019-10-18 2:15 ` zhong jiang
2019-10-18 14:00 ` zhong jiang
2019-10-18 16:07 ` Alexander Duyck
2019-10-21 15:11 ` zhong jiang
2019-10-21 12:57 ` Vlastimil Babka
2019-10-21 13:47 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016174955.300d5fd4968537151d3ad43f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=ira.weiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).