* [patch 24/26] mm/thp: allow dropping THP from page cache
@ 2019-10-19 3:20 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2019-10-19 3:20 UTC (permalink / raw)
To: akpm, kirill.shutemov, linux-mm, mm-commits, oleg,
songliubraving, srikar, torvalds, william.kucharski, willy,
yang.shi
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: mm/thp: allow dropping THP from page cache
Once a THP is added to the page cache, it cannot be dropped via
/proc/sys/vm/drop_caches. Fix this issue with proper handling in
invalidate_mapping_pages().
Link: http://lkml.kernel.org/r/20191017164223.2762148-5-songliubraving@fb.com
Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS")
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Tested-by: Song Liu <songliubraving@fb.com>
Acked-by: Yang Shi <yang.shi@linux.alibaba.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: William Kucharski <william.kucharski@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/truncate.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
--- a/mm/truncate.c~mm-thp-allow-drop-thp-from-page-cache
+++ a/mm/truncate.c
@@ -592,6 +592,16 @@ unsigned long invalidate_mapping_pages(s
unlock_page(page);
continue;
}
+
+ /* Take a pin outside pagevec */
+ get_page(page);
+
+ /*
+ * Drop extra pins before trying to invalidate
+ * the huge page.
+ */
+ pagevec_remove_exceptionals(&pvec);
+ pagevec_release(&pvec);
}
ret = invalidate_inode_page(page);
@@ -602,6 +612,8 @@ unsigned long invalidate_mapping_pages(s
*/
if (!ret)
deactivate_file_page(page);
+ if (PageTransHuge(page))
+ put_page(page);
count += ret;
}
pagevec_remove_exceptionals(&pvec);
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-19 3:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-19 3:20 [patch 24/26] mm/thp: allow dropping THP from page cache akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).