From: Hao Lee <haolee.swjtu@gmail.com>
To: akpm@linux-foundation.org
Cc: mgorman@suse.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, haolee.swjtu@gmail.com
Subject: [PATCH] mm: use the existing variable instead of a duplicate statement
Date: Mon, 25 Nov 2019 14:53:20 +0000 [thread overview]
Message-ID: <20191125145320.GA21484@haolee.github.io> (raw)
The address of zone has been stored in variable 'zone', so there is no need
to get it again with a duplicate statement.
Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
---
mm/vmscan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index ee4eecc7e1c2..de4b2d1e66be 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -363,22 +363,21 @@ unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone
for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) {
struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid];
unsigned long size;
if (!managed_zone(zone))
continue;
if (!mem_cgroup_disabled())
size = mem_cgroup_get_zone_lru_size(lruvec, lru, zid);
else
- size = zone_page_state(&lruvec_pgdat(lruvec)->node_zones[zid],
- NR_ZONE_LRU_BASE + lru);
+ size = zone_page_state(zone, NR_ZONE_LRU_BASE + lru);
lru_size -= min(size, lru_size);
}
return lru_size;
}
/*
* Add a shrinker callback to be called from the vm.
*/
--
2.14.5
next reply other threads:[~2019-11-25 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 14:53 Hao Lee [this message]
2019-11-25 15:18 ` [PATCH] mm: use the existing variable instead of a duplicate statement Mel Gorman
2019-11-26 12:13 ` David Hildenbrand
2019-11-26 14:33 ` Hao Lee
2019-11-28 10:02 ` Anshuman Khandual
2019-11-28 15:12 ` Hao Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125145320.GA21484@haolee.github.io \
--to=haolee.swjtu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).