From: Hao Lee <haolee.swjtu@gmail.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: akpm@linux-foundation.org, Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: use the existing variable instead of a duplicate statement
Date: Thu, 28 Nov 2019 23:12:10 +0800 [thread overview]
Message-ID: <CA+PpKPnA2n+inG7nP0V66Q_-4LNn_nYZa2dqvHTz1fKT2J7e+Q@mail.gmail.com> (raw)
In-Reply-To: <c8e88092-ddbe-2934-aa61-5db6cbad0c11@arm.com>
On Thu, 28 Nov 2019 at 18:02, Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index ee4eecc7e1c2..de4b2d1e66be 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -363,22 +363,21 @@ unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone
> > for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) {
> > struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid];
> > unsigned long size;
> >
> > if (!managed_zone(zone))
> > continue;
> >
> > if (!mem_cgroup_disabled())
> > size = mem_cgroup_get_zone_lru_size(lruvec, lru, zid);
> > else
> > - size = zone_page_state(&lruvec_pgdat(lruvec)->node_zones[zid],
> > - NR_ZONE_LRU_BASE + lru);
> > + size = zone_page_state(zone, NR_ZONE_LRU_BASE + lru);
>
> Is not this already merged with following commit on next-20191126 ?
>
> 54eacdb0dd8f9a ("mm: vmscan: simplify lruvec_lru_size()")
Yes...That's really a coincidence... I use torvalds' tree to develop
but never think this function has been refactored on next tree just a
few days ago. Thank you.
Regards,
Hao Lee
prev parent reply other threads:[~2019-11-28 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 14:53 [PATCH] mm: use the existing variable instead of a duplicate statement Hao Lee
2019-11-25 15:18 ` Mel Gorman
2019-11-26 12:13 ` David Hildenbrand
2019-11-26 14:33 ` Hao Lee
2019-11-28 10:02 ` Anshuman Khandual
2019-11-28 15:12 ` Hao Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+PpKPnA2n+inG7nP0V66Q_-4LNn_nYZa2dqvHTz1fKT2J7e+Q@mail.gmail.com \
--to=haolee.swjtu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).