From: Wei Yang <richardw.yang@linux.intel.com>
To: Baoquan He <bhe@redhat.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, david@redhat.com, osalvador@suse.de,
dan.j.williams@intel.com, mhocko@suse.com, rppt@linux.ibm.com,
robin.murphy@arm.com
Subject: Re: [PATCH v2 6/7] mm/sparse.c: move subsection_map related codes together
Date: Fri, 21 Feb 2020 05:52:13 +0800 [thread overview]
Message-ID: <20200220215213.GA14195@richard> (raw)
In-Reply-To: <20200220085559.GE4937@MiWiFi-R3L-srv>
On Thu, Feb 20, 2020 at 04:55:59PM +0800, Baoquan He wrote:
>On 02/20/20 at 03:12pm, Wei Yang wrote:
>> On Thu, Feb 20, 2020 at 03:04:20PM +0800, Baoquan He wrote:
>> >On 02/20/20 at 02:18pm, Wei Yang wrote:
>> >> On Thu, Feb 20, 2020 at 12:33:15PM +0800, Baoquan He wrote:
>> >> >No functional change.
>> >> >
>> >>
>> >> Those functions are introduced in your previous patches.
>> >>
>> >> Is it possible to define them close to each other at the very beginning?
>> >
>> >Thanks for reviewing.
>> >
>> >Do you mean to discard this patch and keep it as they are in the patch 4/7?
>> >If yes, it's fine to me to drop it as you suggested. To me, I prefer to put
>> >all subsection map handling codes together.
>> >
>>
>> I mean when you introduce clear_subsection_map() in patch 3, is it possible to
>> move close to the definition of fill_subsection_map()?
>>
>> Since finally you are will to move them together.
>
>Oh, got it. Yeah, I just put them close to their callers separately. I
>think it's also good to put them together as you suggested, but it
>doesn't matter much, right? I will consider this and see if I can adjust
>it if v3 is needed. Thanks.
Yes, doesn't matter much.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-02-20 21:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 4:33 [PATCH v2 0/7] mm/hotplug: Only use subsection map in VMEMMAP case Baoquan He
2020-02-20 4:33 ` [PATCH v2 1/7] mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case Baoquan He
2020-02-20 6:11 ` Wei Yang
2020-02-20 12:07 ` David Hildenbrand
2020-02-26 12:31 ` David Hildenbrand
2020-02-26 13:07 ` Baoquan He
2020-02-26 18:09 ` Dan Williams
2020-03-03 8:34 ` David Hildenbrand
2020-03-03 8:39 ` Baoquan He
2020-02-20 4:33 ` [PATCH v2 2/7] mm/sparse.c: introduce new function fill_subsection_map() Baoquan He
2020-02-20 6:14 ` Wei Yang
2020-02-28 14:27 ` David Hildenbrand
2020-03-01 4:59 ` Baoquan He
2020-02-20 4:33 ` [PATCH v2 3/7] mm/sparse.c: introduce a new function clear_subsection_map() Baoquan He
2020-02-20 6:15 ` Wei Yang
2020-02-28 14:36 ` David Hildenbrand
2020-03-01 5:20 ` Baoquan He
2020-03-02 15:43 ` David Hildenbrand
2020-03-03 1:53 ` Baoquan He
2020-03-03 8:22 ` Baoquan He
2020-03-03 8:33 ` David Hildenbrand
2020-03-03 8:38 ` Baoquan He
2020-02-20 4:33 ` [PATCH v2 4/7] mm/sparse.c: only use subsection map in VMEMMAP case Baoquan He
2020-02-20 6:17 ` Wei Yang
2020-02-25 9:57 ` Michal Hocko
2020-02-26 3:53 ` Baoquan He
2020-02-26 9:10 ` Michal Hocko
2020-02-28 7:25 ` Baoquan He
2020-02-20 4:33 ` [PATCH v2 5/7] mm/sparse.c: add code comment about sub-section hotplug Baoquan He
2020-02-20 4:33 ` [PATCH v2 6/7] mm/sparse.c: move subsection_map related codes together Baoquan He
2020-02-20 6:18 ` Wei Yang
2020-02-20 7:04 ` Baoquan He
2020-02-20 7:12 ` Wei Yang
2020-02-20 8:55 ` Baoquan He
2020-02-20 21:52 ` Wei Yang [this message]
2020-02-20 4:33 ` [PATCH v2 7/7] mm/sparse.c: Use __get_free_pages() instead in populate_section_memmap() Baoquan He
2020-02-20 10:38 ` [PATCH v2 0/7] mm/hotplug: Only use subsection map in VMEMMAP case Michal Hocko
2020-02-21 14:28 ` Baoquan He
2020-02-25 9:10 ` David Hildenbrand
2020-02-25 10:02 ` Michal Hocko
2020-02-26 3:42 ` Baoquan He
2020-02-26 9:14 ` Michal Hocko
2020-02-26 12:30 ` Baoquan He
2020-02-25 10:03 ` Michal Hocko
2020-02-26 3:44 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220215213.GA14195@richard \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).