* [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings
@ 2020-02-27 10:35 Julia Lawall
2020-02-27 14:50 ` Dmitry Osipenko
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-02-27 10:35 UTC (permalink / raw)
To: Andrew Morton, Dmitry Osipenko; +Cc: kbuild-all, Linux Memory Management List
From: kbuild test robot <lkp@intel.com>
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
CC: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
:::::: branch date: 17 hours ago
:::::: commit date: 2 days ago
Please take the patch only if it's a positive warning. Thanks!
tegra20-apb-dma.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
irq = platform_get_irq(pdev, i);
if (irq < 0) {
ret = irq;
- dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
goto err_pm_disable;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings
2020-02-27 10:35 [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings Julia Lawall
@ 2020-02-27 14:50 ` Dmitry Osipenko
2020-02-27 18:14 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2020-02-27 14:50 UTC (permalink / raw)
To: Julia Lawall, Andrew Morton
Cc: kbuild-all, Linux Memory Management List, linux-tegra, Jon Hunter
27.02.2020 13:35, Julia Lawall пишет:
> From: kbuild test robot <lkp@intel.com>
>
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> CC: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
> commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
> :::::: branch date: 17 hours ago
> :::::: commit date: 2 days ago
>
> Please take the patch only if it's a positive warning. Thanks!
>
> tegra20-apb-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
> irq = platform_get_irq(pdev, i);
> if (irq < 0) {
> ret = irq;
> - dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> goto err_pm_disable;
> }
>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings
2020-02-27 14:50 ` Dmitry Osipenko
@ 2020-02-27 18:14 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2020-02-27 18:14 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Julia Lawall, Andrew Morton, kbuild-all,
Linux Memory Management List, linux-tegra, Jon Hunter
[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]
On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote:
> 27.02.2020 13:35, Julia Lawall пишет:
> > From: kbuild test robot <lkp@intel.com>
> >
> > Remove dev_err() messages after platform_get_irq*() failures.
> > platform_get_irq() already prints an error.
> >
> > Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> >
> > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> > CC: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
> > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
> > :::::: branch date: 17 hours ago
> > :::::: commit date: 2 days ago
> >
> > Please take the patch only if it's a positive warning. Thanks!
> >
> > tegra20-apb-dma.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/dma/tegra20-apb-dma.c
> > +++ b/drivers/dma/tegra20-apb-dma.c
> > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
> > irq = platform_get_irq(pdev, i);
> > if (irq < 0) {
> > ret = irq;
> > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> > goto err_pm_disable;
> > }
> >
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-27 18:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 10:35 [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings Julia Lawall
2020-02-27 14:50 ` Dmitry Osipenko
2020-02-27 18:14 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).