* [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused
@ 2020-03-05 16:43 Vincenzo Frascino
2020-03-05 17:22 ` Johannes Weiner
2020-03-05 18:36 ` Chris Down
0 siblings, 2 replies; 3+ messages in thread
From: Vincenzo Frascino @ 2020-03-05 16:43 UTC (permalink / raw)
To: cgroups, linux-mm, linux-kernel
Cc: Vincenzo Frascino, Johannes Weiner, Michal Hocko,
Vladimir Davydov, Andrew Morton
mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP
configuration options are enabled. Having them disabled triggers the
following warning at compile time:
linux/mm/memcontrol.c:4797:13: warning: ‘mem_cgroup_id_get_many’ defined
but not used [-Wunused-function]
static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned
int n)
Make mem_cgroup_id_get_many() __maybe_unused to address the issue.
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
mm/memcontrol.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d09776cd6e10..2b9533ed52f5 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4794,7 +4794,8 @@ static void mem_cgroup_id_remove(struct mem_cgroup *memcg)
}
}
-static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n)
+static void __maybe_unused mem_cgroup_id_get_many(struct mem_cgroup *memcg,
+ unsigned int n)
{
refcount_add(n, &memcg->id.ref);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused
2020-03-05 16:43 [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused Vincenzo Frascino
@ 2020-03-05 17:22 ` Johannes Weiner
2020-03-05 18:36 ` Chris Down
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Weiner @ 2020-03-05 17:22 UTC (permalink / raw)
To: Vincenzo Frascino
Cc: cgroups, linux-mm, linux-kernel, Michal Hocko, Vladimir Davydov,
Andrew Morton
On Thu, Mar 05, 2020 at 04:43:54PM +0000, Vincenzo Frascino wrote:
> mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP
> configuration options are enabled. Having them disabled triggers the
> following warning at compile time:
>
> linux/mm/memcontrol.c:4797:13: warning: ‘mem_cgroup_id_get_many’ defined
> but not used [-Wunused-function]
> static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned
> int n)
>
> Make mem_cgroup_id_get_many() __maybe_unused to address the issue.
>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Thanks Vincenzo.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused
2020-03-05 16:43 [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused Vincenzo Frascino
2020-03-05 17:22 ` Johannes Weiner
@ 2020-03-05 18:36 ` Chris Down
1 sibling, 0 replies; 3+ messages in thread
From: Chris Down @ 2020-03-05 18:36 UTC (permalink / raw)
To: Vincenzo Frascino
Cc: cgroups, linux-mm, linux-kernel, Johannes Weiner, Michal Hocko,
Vladimir Davydov, Andrew Morton
Vincenzo Frascino writes:
>mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP
>configuration options are enabled. Having them disabled triggers the
>following warning at compile time:
>
>linux/mm/memcontrol.c:4797:13: warning: ‘mem_cgroup_id_get_many’ defined
>but not used [-Wunused-function]
> static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned
> int n)
>
>Make mem_cgroup_id_get_many() __maybe_unused to address the issue.
>
>Cc: Johannes Weiner <hannes@cmpxchg.org>
>Cc: Michal Hocko <mhocko@kernel.org>
>Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
>Cc: Andrew Morton <akpm@linux-foundation.org>
>Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Thanks, I didn't notice you've already posted it before replying on v1 :-)
Acked-by: Chris Down <chris@chrisdown.name>
>---
> mm/memcontrol.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>index d09776cd6e10..2b9533ed52f5 100644
>--- a/mm/memcontrol.c
>+++ b/mm/memcontrol.c
>@@ -4794,7 +4794,8 @@ static void mem_cgroup_id_remove(struct mem_cgroup *memcg)
> }
> }
>
>-static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n)
>+static void __maybe_unused mem_cgroup_id_get_many(struct mem_cgroup *memcg,
>+ unsigned int n)
> {
> refcount_add(n, &memcg->id.ref);
> }
>--
>2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-05 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 16:43 [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused Vincenzo Frascino
2020-03-05 17:22 ` Johannes Weiner
2020-03-05 18:36 ` Chris Down
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).