From: Baoquan He <bhe@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, mhocko@suse.com,
richardw.yang@linux.intel.com, dan.j.williams@intel.com,
osalvador@suse.de, rppt@linux.ibm.com
Subject: Re: [PATCH v3 3/7] mm/sparse.c: introduce a new function clear_subsection_map()
Date: Mon, 9 Mar 2020 22:07:53 +0800 [thread overview]
Message-ID: <20200309140753.GF27711@MiWiFi-R3L-srv> (raw)
In-Reply-To: <504654de-a9e1-3b95-1ef1-147f18eb0834@redhat.com>
On 03/09/20 at 02:38pm, David Hildenbrand wrote:
> On 09.03.20 14:32, Baoquan He wrote:
> > On 03/09/20 at 09:59am, David Hildenbrand wrote:
> >> On 07.03.20 09:42, Baoquan He wrote:
> >>> Factor out the code which clear subsection map of one memory region from
> >>> section_deactivate() into clear_subsection_map().
> >>>
> >>> Signed-off-by: Baoquan He <bhe@redhat.com>
> >>> ---
> >>> mm/sparse.c | 31 ++++++++++++++++++++++++-------
> >>> 1 file changed, 24 insertions(+), 7 deletions(-)
> >>>
> >>> diff --git a/mm/sparse.c b/mm/sparse.c
> >>> index e37c0abcdc89..d9dcd58d5c1d 100644
> >>> --- a/mm/sparse.c
> >>> +++ b/mm/sparse.c
> >>> @@ -726,15 +726,11 @@ static void free_map_bootmem(struct page *memmap)
> >>> }
> >>> #endif /* CONFIG_SPARSEMEM_VMEMMAP */
> >>>
> >>> -static void section_deactivate(unsigned long pfn, unsigned long nr_pages,
> >>> - struct vmem_altmap *altmap)
> >>> +static int clear_subsection_map(unsigned long pfn, unsigned long nr_pages)
> >>> {
> >>> DECLARE_BITMAP(map, SUBSECTIONS_PER_SECTION) = { 0 };
> >>> DECLARE_BITMAP(tmp, SUBSECTIONS_PER_SECTION) = { 0 };
> >>> struct mem_section *ms = __pfn_to_section(pfn);
> >>> - bool section_is_early = early_section(ms);
> >>> - struct page *memmap = NULL;
> >>> - bool empty = false;
> >>> unsigned long *subsection_map = ms->usage
> >>> ? &ms->usage->subsection_map[0] : NULL;
> >>>
> >>> @@ -745,8 +741,31 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages,
> >>> if (WARN(!subsection_map || !bitmap_equal(tmp, map, SUBSECTIONS_PER_SECTION),
> >>> "section already deactivated (%#lx + %ld)\n",
> >>> pfn, nr_pages))
> >>> + return -EINVAL;
> >>> +
> >>> + bitmap_xor(subsection_map, map, subsection_map, SUBSECTIONS_PER_SECTION);
> >>> +
> >>
> >> Nit: I'd drop this line.
> >
> > It's fine to me. I usually keep one line for the returning. I will
> > remove it when update.
> >
> >>
> >>> + return 0;
> >>> +}
> >>> +
> >>> +static bool is_subsection_map_empty(struct mem_section *ms)
> >>> +{
> >>> + return bitmap_empty(&ms->usage->subsection_map[0],
> >>> + SUBSECTIONS_PER_SECTION);
> >>> +}
> >>> +
> >>> +static void section_deactivate(unsigned long pfn, unsigned long nr_pages,
> >>> + struct vmem_altmap *altmap)
> >>> +{
> >>> + struct mem_section *ms = __pfn_to_section(pfn);
> >>> + bool section_is_early = early_section(ms);
> >>> + struct page *memmap = NULL;
> >>> + bool empty = false;
> >>
> >> Nit: No need to initialize empty.
> >
> > This is inherited from patch 1.
> >
> >>
> >>> +
> >>> + if (clear_subsection_map(pfn, nr_pages))
> >>> return;
> >>>
> >>
> >> Nit: I'd drop this empty line.
> >>
> >>> + empty = is_subsection_map_empty(ms);
> >>> /*
> >>> * There are 3 cases to handle across two configurations
> >>> * (SPARSEMEM_VMEMMAP={y,n}):
> >>> @@ -764,8 +783,6 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages,
> >>> *
> >>> * For 2/ and 3/ the SPARSEMEM_VMEMMAP={y,n} cases are unified
> >>> */
> >>> - bitmap_xor(subsection_map, map, subsection_map, SUBSECTIONS_PER_SECTION);
> >>> - empty = bitmap_empty(subsection_map, SUBSECTIONS_PER_SECTION);
> >>
> >> I do wonder why you moved this up the comment?
> >
> > Since this empty will cover two places of handling, so moved it up,
> > seems this is what I was thinking. Can move it back here.
>
> You're moving the whole comment later, was just wondering (makes it
> slightly harder to review).
I see, sorry for the confusion. I will move it back when repost.
next prev parent reply other threads:[~2020-03-09 14:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 8:42 [PATCH v3 0/7] mm/hotplug: Only use subsection map for VMEMMAP Baoquan He
2020-03-07 8:42 ` [PATCH v3 1/7] mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case Baoquan He
2020-03-07 20:59 ` Andrew Morton
2020-03-07 22:55 ` Baoquan He
2020-03-09 8:56 ` David Hildenbrand
2020-03-09 8:58 ` David Hildenbrand
2020-03-09 13:18 ` Baoquan He
2020-03-09 13:22 ` David Hildenbrand
2020-03-09 10:13 ` Pankaj Gupta
2020-03-09 12:56 ` Michal Hocko
2020-03-07 8:42 ` [PATCH v3 2/7] mm/sparse.c: introduce new function fill_subsection_map() Baoquan He
2020-03-07 8:42 ` [PATCH v3 3/7] mm/sparse.c: introduce a new function clear_subsection_map() Baoquan He
2020-03-09 8:59 ` David Hildenbrand
2020-03-09 13:32 ` Baoquan He
2020-03-09 13:38 ` David Hildenbrand
2020-03-09 14:07 ` Baoquan He [this message]
2020-03-07 8:42 ` [PATCH v3 4/7] mm/sparse.c: only use subsection map in VMEMMAP case Baoquan He
2020-03-09 9:00 ` David Hildenbrand
2020-03-07 8:42 ` [PATCH v3 5/7] mm/sparse.c: add note about only VMEMMAP supporting sub-section support Baoquan He
2020-03-07 11:55 ` Baoquan He
2020-03-10 14:46 ` Michal Hocko
2020-03-11 4:20 ` Baoquan He
2020-03-07 8:42 ` [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together Baoquan He
2020-03-09 9:08 ` David Hildenbrand
2020-03-09 13:41 ` Baoquan He
2020-03-07 8:42 ` [PATCH v3 7/7] mm/sparse.c: Use __get_free_pages() instead in populate_section_memmap() Baoquan He
2020-03-10 14:56 ` Michal Hocko
2020-03-10 14:59 ` David Hildenbrand
2020-03-11 9:31 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309140753.GF27711@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=richardw.yang@linux.intel.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).