From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?
Date: Wed, 11 Mar 2020 14:57:29 +0100 [thread overview]
Message-ID: <20200311145729.4bf95be4@xps13> (raw)
In-Reply-To: <20200310183308.fc664e38002f1ff596b1ddb1@linux-foundation.org>
Hello,
Andrew Morton <akpm@linux-foundation.org> wrote on Tue, 10 Mar 2020
18:33:08 -0700:
> On Wed, 11 Mar 2020 08:12:05 +0800 kbuild test robot <lkp@intel.com> wrote:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 134546626849cd6852d6d4bf8f207b5fbc54261b
> > commit: 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0 [7020/7467] mtd: implement proper partition handling
> > reproduce:
> > # apt-get install sparse
> > # sparse version: v0.6.1-174-g094d5a94-dirty
> > git checkout 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0
> > make ARCH=x86_64 allmodconfig
> > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> >
> > sparse warnings: (new ones prefixed by >>)
> >
> > >> drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?
> >
> > Please review and possibly fold the followup patch.
> >
>
> Something has gone screwy lately. This is not a -mm patch and I've
> never seen it before!
>
> Let's Cc the author, Miquel.
This is indeed a patch that I applied recently on mtd/next, pulled in
linux-next. I have no idea why you did receive this bug report though
:)
That was actually the first time working with sparse for me, it took me
some time (and a lot of build time) to figure out that I had to use the
exact same sparse version has you in order to get the warning (I was
using Ubuntu's stable 0.6.0-3 version).
However I got it working and fixed this trivial but real issue in my
code.
Thanks,
Miquèl
prev parent reply other threads:[~2020-03-11 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 0:12 [linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static? kbuild test robot
2020-03-11 0:12 ` [RFC PATCH linux-next] mtd: __del_mtd_partitions() can be static kbuild test robot
2020-03-11 1:33 ` [linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static? Andrew Morton
2020-03-11 13:57 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311145729.4bf95be4@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).