From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Bharata B Rao <bharata@linux.ibm.com>,
Christopher Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Mel Gorman <mgorman@techsingularity.net>,
Michael Ellerman <mpe@ellerman.id.au>,
Michal Hocko <mhocko@kernel.org>,
Nathan Lynch <nathanl@linux.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
PUVICHAKRAVARTHY RAMACHANDRAN <puvichakravarthy@in.ibm.com>,
Sachin Sant <sachinp@linux.vnet.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] Revert "topology: add support for node_to_mem_node() to determine the fallback node"
Date: Wed, 25 Mar 2020 17:54:33 -0700 [thread overview]
Message-ID: <20200325175433.d5ff1aeecfc7759e66c3898f@linux-foundation.org> (raw)
In-Reply-To: <bb00dbdc-3d67-366b-f5ba-11d297ebc0a8@suse.cz>
On Tue, 24 Mar 2020 14:00:52 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:
> On 3/20/20 12:55 PM, Vlastimil Babka wrote:
> > This reverts commit ad2c8144418c6a81cefe65379fd47bbe8344cef2.
> >
> > The function node_to_mem_node() was introduced by that commit for use in SLUB
> > on systems with memoryless nodes, but it turned out to be unreliable on some
> > architectures/configurations and a simpler solution exists than fixing it up.
> >
> > Thus the previous commit "mm, slub: prevent kmalloc_node crashes and memory
> > leaks" removed the only user of node_to_mem_node() and we can revert the commit
> > that introduced it.
>
> Since the bugfix was fast-tracked to Linus, we can now reference it properly and
> replace the second paragraph with:
>
> Thus commit 0715e6c516f1 ("mm, slub: prevent kmalloc_node crashes and memory
> leaks") removed the only user of node_to_mem_node() and we can revert the commit
> that introduced the function.
I updated the changelog, thanks.
next prev parent reply other threads:[~2020-03-26 0:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 11:55 [PATCH 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks Vlastimil Babka
2020-03-20 11:55 ` [PATCH 2/2] Revert "topology: add support for node_to_mem_node() to determine the fallback node" Vlastimil Babka
2020-03-20 13:12 ` Srikar Dronamraju
2020-03-24 13:00 ` Vlastimil Babka
2020-03-26 0:54 ` Andrew Morton [this message]
2020-03-20 13:10 ` [PATCH 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325175433.d5ff1aeecfc7759e66c3898f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bharata@linux.ibm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=penberg@kernel.org \
--cc=puvichakravarthy@in.ibm.com \
--cc=rientjes@google.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).