Re: [PATCH 3/8] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites

From: kbuild test robot <lkp@intel.com>
To: Michel Lespinasse <walken@google.com>
Cc: kbuild-all@lists.01.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 3/8] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
Date: Fri, 27 Mar 2020 08:40:41 +0800	[thread overview]
Message-ID: <202003270804.COoBkGkB%lkp@intel.com> (raw)
In-Reply-To: <20200326070236.235835-4-walken@google.com>

[-- Attachment #1: Type: text/plain, Size: 2732 bytes --]

Hi Michel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rdma/for-next]
[also build test ERROR on linus/master v5.6-rc7]
[cannot apply to powerpc/next next-20200326]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Michel-Lespinasse/Add-a-new-mmap-locking-API-wrapping-mmap_sem-calls/20200327-035215
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: s390-randconfig-a001-20200326 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/dma-buf/dma-resv.c: In function 'dma_resv_lockdep':
>> drivers/dma-buf/dma-resv.c:112:2: error: implicit declaration of function 'mmap_read_lock'; did you mean '_raw_read_lock'? [-Werror=implicit-function-declaration]
     112 |  mmap_read_lock(mm);
         |  ^~~~~~~~~~~~~~
         |  _raw_read_lock
>> drivers/dma-buf/dma-resv.c:121:2: error: implicit declaration of function 'mmap_read_unlock'; did you mean '_raw_read_unlock'? [-Werror=implicit-function-declaration]
     121 |  mmap_read_unlock(mm);
         |  ^~~~~~~~~~~~~~~~
         |  _raw_read_unlock
   cc1: some warnings being treated as errors

vim +112 drivers/dma-buf/dma-resv.c

    98	
    99	#if IS_ENABLED(CONFIG_LOCKDEP)
   100	static int __init dma_resv_lockdep(void)
   101	{
   102		struct mm_struct *mm = mm_alloc();
   103		struct ww_acquire_ctx ctx;
   104		struct dma_resv obj;
   105		int ret;
   106	
   107		if (!mm)
   108			return -ENOMEM;
   109	
   110		dma_resv_init(&obj);
   111	
 > 112		mmap_read_lock(mm);
   113		ww_acquire_init(&ctx, &reservation_ww_class);
   114		ret = dma_resv_lock(&obj, &ctx);
   115		if (ret == -EDEADLK)
   116			dma_resv_lock_slow(&obj, &ctx);
   117		fs_reclaim_acquire(GFP_KERNEL);
   118		fs_reclaim_release(GFP_KERNEL);
   119		ww_mutex_unlock(&obj.lock);
   120		ww_acquire_fini(&ctx);
 > 121		mmap_read_unlock(mm);
   122		
   123		mmput(mm);
   124	
   125		return 0;
   126	}
   127	subsys_initcall(dma_resv_lockdep);
   128	#endif
   129	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20707 bytes --]