From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
jroedel@suse.de, vbabka@suse.cz, urezki@gmail.com,
Thomas Gleixner <tglx@linutronix.de>,
Olof Johansson <olof@lixom.net>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments
Date: Mon, 6 Apr 2020 16:06:34 +0200 [thread overview]
Message-ID: <20200406140634.GM20730@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200406130155.GB29306@infradead.org>
On Mon, Apr 06, 2020 at 06:01:55AM -0700, Christoph Hellwig wrote:
> On Fri, Apr 03, 2020 at 06:32:53PM +0200, Peter Zijlstra wrote:
> >
> > __get_vm_area() is an exported symbol, make sure the callers stay in
> > the expected memory range. When calling this function with memory
> > ranges outside of the VMALLOC range *bad* things can happen.
> >
> > (I noticed this when I managed to corrupt the kernel text by accident)
>
> Maybe it is time to unexport it? There are only two users:
>
> - staging/media/ipu3 really should be using vmap. And given that it
> is a staging driver it really doesn't matter anyway if we break it.
> - pcmcia/electra_cf.c is actually using it for something that is not
> a vmalloc address. But it is so special that I think prohibiting
> to build it as module seems fine.
I think I just sent you a patch along those lines ;-)
next prev parent reply other threads:[~2020-04-06 14:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:32 [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments Peter Zijlstra
2020-04-03 18:18 ` Uladzislau Rezki
2020-04-03 18:53 ` Peter Zijlstra
2020-04-04 19:00 ` Uladzislau Rezki
2020-04-06 13:01 ` Christoph Hellwig
2020-04-06 14:06 ` Peter Zijlstra [this message]
2020-04-17 12:57 ` Sakari Ailus
2020-04-17 13:14 ` Peter Zijlstra
2020-04-17 13:38 ` Sakari Ailus
2020-04-04 15:35 William Kucharski
2020-04-04 18:52 ` Uladzislau Rezki
2020-04-05 5:25 ` William Kucharski
2020-04-05 17:23 ` Uladzislau Rezki
2020-04-05 19:21 ` Uladzislau Rezki
2020-04-05 20:49 ` William Kucharski
2020-04-06 12:59 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406140634.GM20730@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mchehab@kernel.org \
--cc=olof@lixom.net \
--cc=sakari.ailus@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).