linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: William Kucharski <william.kucharski@oracle.com>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	jroedel@suse.de, vbabka@suse.cz,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments
Date: Sat, 4 Apr 2020 23:25:45 -0600	[thread overview]
Message-ID: <EEB53CBF-0B3F-43E0-94F6-B001918BAC3E@oracle.com> (raw)
In-Reply-To: <20200404185229.GA424@pc636>



> On Apr 4, 2020, at 12:52 PM, Uladzislau Rezki <urezki@gmail.com> wrote:
> 
>> 
>> Is there any need to similarly sanitize “size” to assure start + size doesn’t go past “end?”
>> 
> Why is that double check needed if all such tests are done deeper on stack?

If such tests ARE performed, then it doesn't matter to me whether it is checked before or after,
it just seems that nothing checks whether start + size makes some sort of sense with respect
to end.

I admit I didn't walk through all the routines to see if such a check would be superfluous.



  reply	other threads:[~2020-04-05  5:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-04 15:35 [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments William Kucharski
2020-04-04 18:52 ` Uladzislau Rezki
2020-04-05  5:25   ` William Kucharski [this message]
2020-04-05 17:23     ` Uladzislau Rezki
2020-04-05 19:21       ` Uladzislau Rezki
2020-04-05 20:49         ` William Kucharski
2020-04-06 12:59           ` Uladzislau Rezki
  -- strict thread matches above, loose matches on Subject: below --
2020-04-03 16:32 Peter Zijlstra
2020-04-03 18:18 ` Uladzislau Rezki
2020-04-03 18:53   ` Peter Zijlstra
2020-04-04 19:00     ` Uladzislau Rezki
2020-04-06 13:01 ` Christoph Hellwig
2020-04-06 14:06   ` Peter Zijlstra
2020-04-17 12:57   ` Sakari Ailus
2020-04-17 13:14     ` Peter Zijlstra
2020-04-17 13:38       ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EEB53CBF-0B3F-43E0-94F6-B001918BAC3E@oracle.com \
    --to=william.kucharski@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).