From: Michal Hocko <mhocko@kernel.org>
To: svc_lmoiseichuk@magicleap.com
Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, tj@kernel.org,
lizefan@huawei.com, cgroups@vger.kernel.org,
akpm@linux-foundation.org, rientjes@google.com,
minchan@kernel.org, vinmenon@codeaurora.org,
andriy.shevchenko@linux.intel.com, anton.vorontsov@linaro.org,
penberg@kernel.org, linux-mm@kvack.org,
Leonid Moiseichuk <lmoiseichuk@magicleap.com>
Subject: Re: [PATCH 0/2] memcg, vmpressure: expose vmpressure controls
Date: Tue, 14 Apr 2020 13:37:30 +0200 [thread overview]
Message-ID: <20200414113730.GH4629@dhcp22.suse.cz> (raw)
In-Reply-To: <20200413215750.7239-1-lmoiseichuk@magicleap.com>
On Mon 13-04-20 17:57:48, svc_lmoiseichuk@magicleap.com wrote:
> From: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
>
> Small tweak to populate vmpressure parameters to userspace without
> any built-in logic change.
>
> The vmpressure is used actively (e.g. on Android) to track mm stress.
> vmpressure parameters selected empiricaly quite long time ago and not
> always suitable for modern memory configurations.
This needs much more details. Why it is not suitable? What are usual
numbers you need to set up to work properly? Why those wouldn't be
generally applicable?
Anyway, I have to confess I am not a big fan of this. vmpressure turned
out to be a very weak interface to measure the memory pressure. Not only
it is not numa aware which makes it unusable on many systems it also
gives data way too late from the practice.
Btw. why don't you use /proc/pressure/memory resp. its memcg counterpart
to measure the memory pressure in the first place?
> Leonid Moiseichuk (2):
> memcg: expose vmpressure knobs
> memcg, vmpressure: expose vmpressure controls
>
> .../admin-guide/cgroup-v1/memory.rst | 12 +-
> include/linux/vmpressure.h | 35 ++++++
> mm/memcontrol.c | 113 ++++++++++++++++++
> mm/vmpressure.c | 101 +++++++---------
> 4 files changed, 200 insertions(+), 61 deletions(-)
>
> --
> 2.17.1
>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-04-14 11:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:57 [PATCH 0/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk
2020-04-13 21:57 ` [PATCH 1/2] memcg: expose vmpressure knobs svc_lmoiseichuk
2020-04-14 22:55 ` Chris Down
2020-04-14 23:00 ` Leonid Moiseichuk
2020-04-13 21:57 ` [PATCH 2/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk
2020-04-14 11:37 ` Michal Hocko [this message]
2020-04-14 16:42 ` [PATCH 0/2] " Leonid Moiseichuk
2020-04-14 18:49 ` Michal Hocko
2020-04-14 20:53 ` Leonid Moiseichuk
2020-04-15 7:51 ` Michal Hocko
2020-04-15 12:17 ` Leonid Moiseichuk
2020-04-15 12:28 ` Michal Hocko
2020-04-15 12:33 ` Leonid Moiseichuk
2020-04-14 19:23 ` Johannes Weiner
2020-04-14 22:12 ` Leonid Moiseichuk
2020-04-15 7:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414113730.GH4629@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anton.vorontsov@linaro.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=lmoiseichuk@magicleap.com \
--cc=minchan@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=svc_lmoiseichuk@magicleap.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).