From: Dan Schatzberg <schatzberg.dan@gmail.com>
To: Hillf Danton <hdanton@sina.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 4/4] loop: Charge i/o to mem and blk cg
Date: Tue, 21 Apr 2020 09:57:32 -0400 [thread overview]
Message-ID: <20200421135732.GB9623@dschatzberg-fedora-PC0Y6AEN> (raw)
In-Reply-To: <20200421033337.13208-1-hdanton@sina.com>
On Tue, Apr 21, 2020 at 11:33:37AM +0800, Hillf Danton wrote:
>
> On Mon, 20 Apr 2020 18:39:32 -0400 Dan Schatzberg wrote:
> >
> > @@ -964,13 +960,16 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd)
> > worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN);
> > /*
> > * In the event we cannot allocate a worker, just queue on the
> > - * rootcg worker
> > + * rootcg worker and issue the I/O as the rootcg
> > */
> > - if (!worker)
> > + if (!worker) {
> > + cmd->blkcg_css = NULL;
> > + cmd->memcg_css = NULL;
>
> Dunno if css_put(cmd->memcg_css);
Good catch. Need to drop the reference here.
next prev parent reply other threads:[~2020-04-21 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 22:39 [PATCH 0/4] Charge loop device i/o to issuing cgroup Dan Schatzberg
2020-04-20 22:39 ` [PATCH 1/4] loop: Use worker per cgroup instead of kworker Dan Schatzberg
2020-04-20 22:39 ` [PATCH 2/4] mm: support nesting memalloc_use_memcg() Dan Schatzberg
2020-04-21 0:43 ` Shakeel Butt
2020-04-22 1:13 ` Roman Gushchin
2020-04-20 22:39 ` [PATCH 3/4] mm: Charge active memcg when no mm is set Dan Schatzberg
2020-04-20 22:39 ` [PATCH 4/4] loop: Charge i/o to mem and blk cg Dan Schatzberg
2020-04-21 2:48 ` [PATCH 1/4] loop: Use worker per cgroup instead of kworker Hillf Danton
2020-04-21 13:55 ` Dan Schatzberg
[not found] ` <20200421033337.13208-1-hdanton@sina.com>
2020-04-21 13:57 ` Dan Schatzberg [this message]
2020-05-28 13:54 [PATCH v6 0/4] Charge loop device i/o to issuing cgroup Dan Schatzberg
2020-05-28 13:54 ` [PATCH 4/4] loop: Charge i/o to mem and blk cg Dan Schatzberg
2020-08-24 15:35 [PATCH v7 0/4] Charge loop device i/o to issuing cgroup Dan Schatzberg
2020-08-24 15:36 ` [PATCH 4/4] loop: Charge i/o to mem and blk cg Dan Schatzberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421135732.GB9623@dschatzberg-fedora-PC0Y6AEN \
--to=schatzberg.dan@gmail.com \
--cc=axboe@kernel.dk \
--cc=hdanton@sina.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).