From: SeongJae Park <sjpark@amazon.com>
To: SeongJae Park <sjpark@amazon.com>
Cc: <akpm@linux-foundation.org>, <Jonathan.Cameron@Huawei.com>,
<aarcange@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
<benh@kernel.crashing.org>, <brendan.d.gregg@gmail.com>,
<brendanhiggins@google.com>, <cai@lca.pw>,
<colin.king@canonical.com>, <corbet@lwn.net>, <david@redhat.com>,
<dwmw@amazon.com>, <fan.du@intel.com>, <foersleo@amazon.de>,
<gthelen@google.com>, <irogers@google.com>, <jolsa@redhat.com>,
<kirill@shutemov.name>, <mark.rutland@arm.com>, <mgorman@suse.de>,
<minchan@kernel.org>, <mingo@redhat.com>, <namhyung@kernel.org>,
<peterz@infradead.org>, <rdunlap@infradead.org>,
<riel@surriel.com>, <rientjes@google.com>, <rostedt@goodmis.org>,
<rppt@kernel.org>, <sblbir@amazon.com>, <shakeelb@google.com>,
<shuah@kernel.org>, <sj38.park@gmail.com>, <snu@amazon.de>,
<vbabka@suse.cz>, <vdavydov.dev@gmail.com>,
<yang.shi@linux.alibaba.com>, <ying.huang@intel.com>,
<linux-damon@amazon.com>, <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
SeongJae Park <sjpark@amazon.de>
Subject: Re: [RFC v6 00/10] DAMON: Support Physical Memory Address Space Monitoring
Date: Thu, 6 Aug 2020 10:31:55 +0200 [thread overview]
Message-ID: <20200806083155.31432-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200805065951.18221-1-sjpark@amazon.com>
On Wed, 5 Aug 2020 08:59:41 +0200 SeongJae Park <sjpark@amazon.com> wrote:
> From: SeongJae Park <sjpark@amazon.de>
>
> Changes from Previous Version
> =============================
>
> - paddr: Support nested iomem sections (Du Fan)
> - Rebase on v5.8
>
> Introduction
> ============
>
> DAMON[1] programming interface users can extend DAMON for any address space by
> configuring the address-space specific low level primitives with appropriate
> ones including their own implementations. However, because the implementation
> for the virtual address space is only available now, the users should implement
> their own for other address spaces. Worse yet, the user space users who rely
> on the debugfs interface and user space tool, cannot implement their own.
>
> This patchset implements another reference implementation of the low level
> primitives for the physical memory address space. With this change, hence, the
> kernel space users can monitor both the virtual and the physical address spaces
> by simply changing the configuration in the runtime. Further, this patchset
> links the implementation to the debugfs interface and the user space tool for
> the user space users.
>
> Note that the implementation supports only the user memory, as same to the idle
> page access tracking feature.
>
> [1] https://lore.kernel.org/linux-mm/20200706115322.29598-1-sjpark@amazon.com/
This patchset doesn't works for physical address monitoring because I forgot
below patch. Sorry for missing it. Please apply it before you test this
patchset. Or, you can clone the patch applied complete git tree:
$ git clone git://github.com/sjp38/linux -b cdamon/rfc/v6.1
The web is also available:
https://github.com/sjp38/linux/releases/tag/cdamon/rfc/v6.1
The patch will be split and squashed in appropriate patch in the next spin.
=============================== >8 ===========================================
From edf6b586f4ac3f8f4d61ebde56d644422bd93bee Mon Sep 17 00:00:00 2001
From: SeongJae Park <sjpark@amazon.de>
Date: Thu, 6 Aug 2020 08:18:49 +0000
Subject: [PATCH] mm/damon: Fix paddr target id problem
The target id for 'paddr' is meaningless, but we set it as '-1' for fun
and smooth interaction with the user space interfaces. However, the
target ids are 'unsigned long' and thus using '-1' makes no sense. This
commit changes the fake number to another funny but unsigned number,
'42'.
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
Documentation/admin-guide/mm/damon/usage.rst | 4 ++--
mm/damon.c | 2 +-
tools/damon/_damon.py | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst
index 88b8e9254a7e..3e2f1519c96a 100644
--- a/Documentation/admin-guide/mm/damon/usage.rst
+++ b/Documentation/admin-guide/mm/damon/usage.rst
@@ -334,12 +334,12 @@ check it again::
Users can also monitor the physical memory address space of the system by
writing a special keyword, "``paddr\n``" to the file. Because physical address
space monitoring doesn't support multiple targets, reading the file will show a
-fake value, ``-1``, as below::
+fake value, ``42``, as below::
# cd <debugfs>/damon
# echo paddr > target_ids
# cat target_ids
- -1
+ 42
Note that setting the target ids doesn't start the monitoring.
diff --git a/mm/damon.c b/mm/damon.c
index a9757a0e5cf7..66268cb45b51 100644
--- a/mm/damon.c
+++ b/mm/damon.c
@@ -2047,7 +2047,7 @@ static ssize_t debugfs_target_ids_write(struct file *file,
ctx->target_valid = NULL;
/* target id is meaningless here, but we set it just for fun */
- snprintf(kbuf, count, "-1 ");
+ snprintf(kbuf, count, "42 ");
} else {
/* Configure the context for virtual memory monitoring */
ctx->init_target_regions = kdamond_init_vm_regions;
diff --git a/tools/damon/_damon.py b/tools/damon/_damon.py
index cf14a0d59b94..6ff278117e84 100644
--- a/tools/damon/_damon.py
+++ b/tools/damon/_damon.py
@@ -28,7 +28,7 @@ def set_target(tid, init_regions=[]):
return 0
if tid == 'paddr':
- tid = -1
+ tid = 42
string = ' '.join(['%s %d %d' % (tid, r[0], r[1]) for r in init_regions])
return subprocess.call('echo "%s" > %s' % (string, debugfs_init_regions),
shell=True, executable='/bin/bash')
--
2.17.1
prev parent reply other threads:[~2020-08-06 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 6:59 [RFC v6 00/10] DAMON: Support Physical Memory Address Space Monitoring SeongJae Park
2020-08-05 6:59 ` [RFC v6 01/10] mm/damon/debugfs: Allow users to set initial monitoring target regions SeongJae Park
2020-08-05 6:59 ` [RFC v6 02/10] tools/damon: Support init target regions specification SeongJae Park
2020-08-05 6:59 ` [RFC v6 03/10] mm/damon-test: Add more unit tests for 'init_regions' SeongJae Park
2020-08-05 6:59 ` [RFC v6 04/10] selftests/damon/_chk_record: Do not check number of gaps SeongJae Park
2020-08-05 6:59 ` [RFC v6 05/10] Docs/admin-guide/mm/damon: Document 'init_regions' feature SeongJae Park
2020-08-05 6:59 ` [RFC v6 06/10] mm/damon: Implement callbacks for physical memory monitoring SeongJae Park
2020-08-05 6:59 ` [RFC v6 07/10] mm/damon/debugfs: Support " SeongJae Park
2020-08-05 6:59 ` [RFC v6 08/10] tools/damon/record: " SeongJae Park
2020-08-05 6:59 ` [RFC v6 09/10] tools/damon/record: Support NUMA specific recording SeongJae Park
2020-08-05 6:59 ` [RFC v6 10/10] Docs/DAMON: Document physical memory monitoring support SeongJae Park
2020-08-06 8:31 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806083155.31432-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendan.d.gregg@gmail.com \
--cc=brendanhiggins@google.com \
--cc=cai@lca.pw \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=gthelen@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sblbir@amazon.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).