* [PATCH] mm/memcg: no one use charge_type
@ 2020-09-08 8:12 Alex Shi
2020-09-08 8:13 ` Chris Down
2020-09-08 8:27 ` Michal Hocko
0 siblings, 2 replies; 3+ messages in thread
From: Alex Shi @ 2020-09-08 8:12 UTC (permalink / raw)
Cc: Johannes Weiner, Michal Hocko, Vladimir Davydov, Andrew Morton,
cgroups, linux-mm, linux-kernel
After commit 0a31bc97c80c3f mm: memcontrol: rewrite uncharge API, no one
using MEM_CGROUP_CHARGE_TYPE_xxx, let's remove them.
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: cgroups@vger.kernel.org
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
---
mm/memcontrol.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 5d52b8a88bea..d925905920bf 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -199,14 +199,6 @@ struct mem_cgroup_event {
#define MEM_CGROUP_MAX_RECLAIM_LOOPS 100
#define MEM_CGROUP_MAX_SOFT_LIMIT_RECLAIM_LOOPS 2
-enum charge_type {
- MEM_CGROUP_CHARGE_TYPE_CACHE = 0,
- MEM_CGROUP_CHARGE_TYPE_ANON,
- MEM_CGROUP_CHARGE_TYPE_SWAPOUT, /* for accounting swapcache */
- MEM_CGROUP_CHARGE_TYPE_DROP, /* a page was unused swap cache */
- NR_CHARGE_TYPE,
-};
-
/* for encoding cft->private value on file */
enum res_type {
_MEM,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/memcg: no one use charge_type
2020-09-08 8:12 [PATCH] mm/memcg: no one use charge_type Alex Shi
@ 2020-09-08 8:13 ` Chris Down
2020-09-08 8:27 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: Chris Down @ 2020-09-08 8:13 UTC (permalink / raw)
To: Alex Shi
Cc: Johannes Weiner, Michal Hocko, Vladimir Davydov, Andrew Morton,
cgroups, linux-mm, linux-kernel
Alex Shi writes:
>After commit 0a31bc97c80c3f mm: memcontrol: rewrite uncharge API, no one
>using MEM_CGROUP_CHARGE_TYPE_xxx, let's remove them.
>
>Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
>Cc: Johannes Weiner <hannes@cmpxchg.org>
>Cc: Michal Hocko <mhocko@kernel.org>
>Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
>Cc: Andrew Morton <akpm@linux-foundation.org>
>Cc: cgroups@vger.kernel.org
>Cc: linux-mm@kvack.org
>Cc: linux-kernel@vger.kernel.org
Acked-by: Chris Down <chris@chrisdown.name>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/memcg: no one use charge_type
2020-09-08 8:12 [PATCH] mm/memcg: no one use charge_type Alex Shi
2020-09-08 8:13 ` Chris Down
@ 2020-09-08 8:27 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2020-09-08 8:27 UTC (permalink / raw)
To: Alex Shi
Cc: Johannes Weiner, Vladimir Davydov, Andrew Morton, cgroups,
linux-mm, linux-kernel
On Tue 08-09-20 16:12:07, Alex Shi wrote:
> After commit 0a31bc97c80c3f mm: memcontrol: rewrite uncharge API, no one
> using MEM_CGROUP_CHARGE_TYPE_xxx, let's remove them.
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: cgroups@vger.kernel.org
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> mm/memcontrol.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 5d52b8a88bea..d925905920bf 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -199,14 +199,6 @@ struct mem_cgroup_event {
> #define MEM_CGROUP_MAX_RECLAIM_LOOPS 100
> #define MEM_CGROUP_MAX_SOFT_LIMIT_RECLAIM_LOOPS 2
>
> -enum charge_type {
> - MEM_CGROUP_CHARGE_TYPE_CACHE = 0,
> - MEM_CGROUP_CHARGE_TYPE_ANON,
> - MEM_CGROUP_CHARGE_TYPE_SWAPOUT, /* for accounting swapcache */
> - MEM_CGROUP_CHARGE_TYPE_DROP, /* a page was unused swap cache */
> - NR_CHARGE_TYPE,
> -};
> -
> /* for encoding cft->private value on file */
> enum res_type {
> _MEM,
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-08 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 8:12 [PATCH] mm/memcg: no one use charge_type Alex Shi
2020-09-08 8:13 ` Chris Down
2020-09-08 8:27 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).