* [PATCH] mm,slab_common: use list_for_each_entry in dump_unreclaimable_slab()
@ 2020-09-26 4:34 Hui Su
0 siblings, 0 replies; only message in thread
From: Hui Su @ 2020-09-26 4:34 UTC (permalink / raw)
To: cl, penberg, rientjes, iamjoonsoo.kim, akpm, linux-mm, linux-kernel
dump_unreclaimable_slab() acquires the slab_mutex first,
and it won't remove any slab_caches list entry when
itering the slab_caches lists.
Thus, we do not need list_for_each_entry_safe here,
which is against removal of list entry.
Signed-off-by: Hui Su <sh_def@163.com>
---
mm/slab_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index f9ccd5dc13f3..0cd2821b7066 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -978,7 +978,7 @@ static int slab_show(struct seq_file *m, void *p)
void dump_unreclaimable_slab(void)
{
- struct kmem_cache *s, *s2;
+ struct kmem_cache *s;
struct slabinfo sinfo;
/*
@@ -996,7 +996,7 @@ void dump_unreclaimable_slab(void)
pr_info("Unreclaimable slab info:\n");
pr_info("Name Used Total\n");
- list_for_each_entry_safe(s, s2, &slab_caches, list) {
+ list_for_each_entry(s, &slab_caches, list) {
if (s->flags & SLAB_RECLAIM_ACCOUNT)
continue;
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-26 4:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26 4:34 [PATCH] mm,slab_common: use list_for_each_entry in dump_unreclaimable_slab() Hui Su
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).