From: Andrew Morton <akpm@linux-foundation.org>
To: Hui Su <sh_def@163.com>
Cc: Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/oom_kill: remove comment and rename is_dump_unreclaim_slabs()
Date: Wed, 28 Oct 2020 14:53:30 -0700 [thread overview]
Message-ID: <20201028145330.1cf7a32bb109ccb50d2b0dbb@linux-foundation.org> (raw)
In-Reply-To: <20201028153141.GB77196@rlk>
On Wed, 28 Oct 2020 23:31:41 +0800 Hui Su <sh_def@163.com> wrote:
> Comment for is_dump_unreclaim_slabs is not really clear whether it is
> meant to instruct how to use the function or whether it is an outdated
> information of the past implementation of the function. it doesn't realy
> help that is_dump_unreclaim_slabs is hard to grasp on its own.
>
> Rename the helper to should_dump_unreclaim_slabs which should make it
> clear what it is meant to do and drop the comment as the purpose
> should be pretty evident now.
>
I think your recent attempt to improve the comment:
/*
* Check whether unreclaimable slabs amount is greater than all user
* memory(LRU pages).
*/
was actually somewhat useful, and worth retaining.
It would be better if it explained *why* we're doing this, rather than
simply "what we are doing"?
<looks at the code>
It's actually quite unobvious why we're doing this!
next prev parent reply other threads:[~2020-10-28 21:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201027144529.GA3558@rlk>
2020-10-27 14:58 ` [PATCH v2] mm/oom_kill.c: remove the unmatched comments Michal Hocko
2020-10-27 15:11 ` Hui Su
2020-10-27 19:23 ` Michal Hocko
2020-10-28 15:31 ` [PATCH v3] mm/oom_kill: remove comment and rename is_dump_unreclaim_slabs() Hui Su
2020-10-28 21:53 ` Andrew Morton [this message]
2020-10-29 7:51 ` Michal Hocko
2020-10-30 18:27 ` [PATCH v4] mm/oom_kill: change " Hui Su
2020-11-02 7:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028145330.1cf7a32bb109ccb50d2b0dbb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=sh_def@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).