From: Christoph Hellwig <hch@lst.de>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de,
kent.overstreet@gmail.com
Subject: Re: [PATCH v2 16/18] mm/filemap: Don't relock the page after calling readpage
Date: Fri, 6 Nov 2020 09:21:52 +0100 [thread overview]
Message-ID: <20201106082152.GJ31585@lst.de> (raw)
In-Reply-To: <20201104204219.23810-17-willy@infradead.org>
On Wed, Nov 04, 2020 at 08:42:17PM +0000, Matthew Wilcox (Oracle) wrote:
> We don't need to get the page lock again; we just need to wait for
> the I/O to finish, so use wait_on_page_locked_killable() like the
> other callers of ->readpage.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Kent Overstreet <kent.overstreet@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
although I still think a little comment would not hurt.
prev parent reply other threads:[~2020-11-06 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201104204219.23810-1-willy@infradead.org>
[not found] ` <20201104204219.23810-2-willy@infradead.org>
2020-11-06 8:07 ` [PATCH v2 01/18] mm/filemap: Rename generic_file_buffered_read subfunctions Christoph Hellwig
[not found] ` <20201104204219.23810-3-willy@infradead.org>
[not found] ` <20201104213005.GB3365678@moria.home.lan>
2020-11-05 4:52 ` [PATCH v2 02/18] mm/filemap: Remove dynamically allocated array from filemap_read Matthew Wilcox
[not found] ` <20201105001302.GF17076@casper.infradead.org>
2020-11-06 8:08 ` Christoph Hellwig
2020-11-06 12:30 ` [PATCH 1/4] pagevec: Allow pagevecs to be different sizes Matthew Wilcox (Oracle)
2020-11-06 12:30 ` [PATCH 2/4] pagevec: Increase the size of LRU pagevecs Matthew Wilcox (Oracle)
2020-11-06 12:30 ` [PATCH 3/4] pagevec: Add dynamically allocated pagevecs Matthew Wilcox (Oracle)
2020-11-06 12:30 ` [PATCH 4/4] mm/filemap: Use a dynamically allocated pagevec in filemap_read Matthew Wilcox (Oracle)
2020-11-07 17:08 ` [PATCH 1/4] pagevec: Allow pagevecs to be different sizes Kent Overstreet
2020-11-07 17:20 ` Matthew Wilcox
2020-11-06 8:07 ` [PATCH v2 02/18] mm/filemap: Remove dynamically allocated array from filemap_read Christoph Hellwig
[not found] ` <20201104204219.23810-4-willy@infradead.org>
2020-11-06 8:08 ` [PATCH v2 03/18] mm/filemap: Convert filemap_get_pages to take a pagevec Christoph Hellwig
[not found] ` <20201104204219.23810-10-willy@infradead.org>
2020-11-06 8:11 ` [PATCH v2 09/18] mm/filemap: Change filemap_read_page calling conventions Christoph Hellwig
[not found] ` <20201104204219.23810-12-willy@infradead.org>
2020-11-06 8:14 ` [PATCH v2 11/18] mm/filemap: Convert filemap_update_page to return an errno Christoph Hellwig
2020-11-06 8:37 ` Christoph Hellwig
2020-11-09 13:29 ` Matthew Wilcox
[not found] ` <20201104204219.23810-14-willy@infradead.org>
2020-11-06 8:16 ` [PATCH v2 13/18] mm/filemap: Add filemap_range_uptodate Christoph Hellwig
[not found] ` <20201104204219.23810-15-willy@infradead.org>
2020-11-06 8:19 ` [PATCH v2 14/18] mm/filemap: Split filemap_readahead out of filemap_get_pages Christoph Hellwig
[not found] ` <20201104204219.23810-16-willy@infradead.org>
2020-11-06 8:21 ` [PATCH v2 15/18] mm/filemap: Restructure filemap_get_pages Christoph Hellwig
[not found] ` <20201104204219.23810-17-willy@infradead.org>
2020-11-06 8:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106082152.GJ31585@lst.de \
--to=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).