From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <guro@fb.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Shakeel Butt <shakeelb@google.com>,
Michal Hocko <mhocko@kernel.org>,
Christoph Lameter <cl@linux.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization
Date: Thu, 12 Nov 2020 10:18:28 -0500 [thread overview]
Message-ID: <20201112151828.GA873621@cmpxchg.org> (raw)
In-Reply-To: <20201110195753.530157-1-guro@fb.com>
On Tue, Nov 10, 2020 at 11:57:52AM -0800, Roman Gushchin wrote:
> It's convenient to have page->objects initialized before calling
> into account_slab_page(). In particular, this information can be
> used to pre-alloc the obj_cgroup vector.
>
> Let's call account_slab_page() a bit later, after the initialization
> of page->objects.
>
> This commit doesn't bring any functional change, but is required for
> further optimizations.
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2020-11-12 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 19:57 [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization Roman Gushchin
2020-11-10 19:57 ` [PATCH 2/2] mm: memcg/slab: pre-allocate obj_cgroups for slab caches with SLAB_ACCOUNT Roman Gushchin
2020-11-10 20:50 ` Andrew Morton
2020-11-10 21:51 ` Roman Gushchin
2020-11-12 16:23 ` Johannes Weiner
2020-11-13 0:19 ` Roman Gushchin
2020-11-13 1:12 ` Andrew Morton
2020-11-13 1:46 ` Roman Gushchin
2020-11-16 15:03 ` Johannes Weiner
2020-11-17 17:42 ` Shakeel Butt
2020-11-17 20:15 ` Roman Gushchin
2020-11-12 15:18 ` Johannes Weiner [this message]
2020-11-17 17:16 ` [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112151828.GA873621@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).