archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <>
Cc: Andrea Arcangeli <>,
	"Kirill A . Shutemov" <>,
	Andrew Morton <>
Subject: Re: [PATCH 0/3] mm: Some rework on zap_details
Date: Tue, 15 Dec 2020 15:39:59 -0500	[thread overview]
Message-ID: <20201215203959.GA6519@xz-x1> (raw)
In-Reply-To: <>

On Mon, Dec 07, 2020 at 09:50:19PM -0500, Peter Xu wrote:
> Posted this small series out to rework zap_details a bit, before adding
> something new in.  Hopefully it makes things slighly clearer.
> Smoke test only.  Please have a look, thanks.
> Peter Xu (3):
>   mm: Drop first_index/last_index in zap_details
>   mm: Introduce zap_details.zap_flags
>   mm: Introduce ZAP_FLAG_SKIP_SWAP

Some more information on "before adding something new in" - the new flag as a
reference but not yet posted anywhere...

I still think this small series worths to be reviewed/merged even before that
new flag, because patch 1 should definitely be something good to have, patch 2
prepares for patch 3 and the new bit (which can be seen as optional), but patch
3 should help make things clearer rather than using non-null "details" pointer
to show "whether we should skip swap entries", which can be easily misused IMHO
when someone accidentally replaced one "details==NULL" with some valid pointer.

Of course I can repost these series with the larger one when time comes too,
but I'd still like to at least get a NO early if there is...


Peter Xu

      parent reply	other threads:[~2020-12-15 20:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  2:50 [PATCH 0/3] mm: Some rework on zap_details Peter Xu
2020-12-08  2:50 ` [PATCH 1/3] mm: Drop first_index/last_index in zap_details Peter Xu
2020-12-08  2:50 ` [PATCH 2/3] mm: Introduce zap_details.zap_flags Peter Xu
2020-12-08  2:50 ` [PATCH 3/3] mm: Introduce ZAP_FLAG_SKIP_SWAP Peter Xu
2020-12-15 20:39 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215203959.GA6519@xz-x1 \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).