* [PATCH] mm/debug: Improve memcg debugging
@ 2021-01-14 19:02 Matthew Wilcox (Oracle)
2021-01-15 2:19 ` Zi Yan
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox (Oracle) @ 2021-01-14 19:02 UTC (permalink / raw)
To: Andrew Morton, linux-mm; +Cc: Matthew Wilcox (Oracle)
The memcg_data is only valid on the head page, not the tail pages.
Change the format and location of the printout within the dump to
match the other parts of struct page better.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
mm/debug.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/mm/debug.c b/mm/debug.c
index 8a40b3fefbeb..0bdda8407f71 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -110,6 +110,11 @@ void __dump_page(struct page *page, const char *reason)
head_compound_mapcount(head));
}
}
+
+#ifdef CONFIG_MEMCG
+ if (head->memcg_data)
+ pr_warn("memcg:%lx\n", head->memcg_data);
+#endif
if (PageKsm(page))
type = "ksm ";
else if (PageAnon(page))
@@ -180,11 +185,6 @@ void __dump_page(struct page *page, const char *reason)
if (reason)
pr_warn("page dumped because: %s\n", reason);
-
-#ifdef CONFIG_MEMCG
- if (!page_poisoned && page->memcg_data)
- pr_warn("pages's memcg:%lx\n", page->memcg_data);
-#endif
}
void dump_page(struct page *page, const char *reason)
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/debug: Improve memcg debugging
2021-01-14 19:02 [PATCH] mm/debug: Improve memcg debugging Matthew Wilcox (Oracle)
@ 2021-01-15 2:19 ` Zi Yan
0 siblings, 0 replies; 2+ messages in thread
From: Zi Yan @ 2021-01-15 2:19 UTC (permalink / raw)
To: Matthew Wilcox (Oracle); +Cc: Andrew Morton, linux-mm
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
On 14 Jan 2021, at 14:02, Matthew Wilcox (Oracle) wrote:
> The memcg_data is only valid on the head page, not the tail pages.
> Change the format and location of the printout within the dump to
> match the other parts of struct page better.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> mm/debug.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/debug.c b/mm/debug.c
> index 8a40b3fefbeb..0bdda8407f71 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -110,6 +110,11 @@ void __dump_page(struct page *page, const char *reason)
> head_compound_mapcount(head));
> }
> }
> +
> +#ifdef CONFIG_MEMCG
> + if (head->memcg_data)
> + pr_warn("memcg:%lx\n", head->memcg_data);
> +#endif
> if (PageKsm(page))
> type = "ksm ";
> else if (PageAnon(page))
> @@ -180,11 +185,6 @@ void __dump_page(struct page *page, const char *reason)
>
> if (reason)
> pr_warn("page dumped because: %s\n", reason);
> -
> -#ifdef CONFIG_MEMCG
> - if (!page_poisoned && page->memcg_data)
> - pr_warn("pages's memcg:%lx\n", page->memcg_data);
> -#endif
> }
>
> void dump_page(struct page *page, const char *reason)
> --
> 2.29.2
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
—
Best Regards,
Yan Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-15 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 19:02 [PATCH] mm/debug: Improve memcg debugging Matthew Wilcox (Oracle)
2021-01-15 2:19 ` Zi Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).