* [PATCH] hugetlbfs: rework calculation code of Hugepage size in hugetlbfs_show_options()
@ 2021-02-01 8:23 Miaohe Lin
2021-02-01 10:56 ` David Hildenbrand
0 siblings, 1 reply; 3+ messages in thread
From: Miaohe Lin @ 2021-02-01 8:23 UTC (permalink / raw)
To: akpm, mike.kravetz; +Cc: linux-mm, linux-kernel, linmiaohe
Rework calculation code of the Hugepage size to make it more readable and
straightforward.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
fs/hugetlbfs/inode.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 3a08fbae3b53..1be18de4b537 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -1014,11 +1014,12 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root)
if (sbinfo->max_inodes != -1)
seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes);
- hpage_size /= 1024;
- mod = 'K';
- if (hpage_size >= 1024) {
- hpage_size /= 1024;
+ if (hpage_size >= SZ_1M) {
+ hpage_size /= SZ_1M;
mod = 'M';
+ } else {
+ hpage_size /= SZ_1K;
+ mod = 'K';
}
seq_printf(m, ",pagesize=%lu%c", hpage_size, mod);
if (spool) {
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hugetlbfs: rework calculation code of Hugepage size in hugetlbfs_show_options()
2021-02-01 8:23 [PATCH] hugetlbfs: rework calculation code of Hugepage size in hugetlbfs_show_options() Miaohe Lin
@ 2021-02-01 10:56 ` David Hildenbrand
2021-02-01 11:19 ` Miaohe Lin
0 siblings, 1 reply; 3+ messages in thread
From: David Hildenbrand @ 2021-02-01 10:56 UTC (permalink / raw)
To: Miaohe Lin, akpm, mike.kravetz; +Cc: linux-mm, linux-kernel
On 01.02.21 09:23, Miaohe Lin wrote:
> Rework calculation code of the Hugepage size to make it more readable and
> straightforward.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> fs/hugetlbfs/inode.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 3a08fbae3b53..1be18de4b537 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1014,11 +1014,12 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root)
> if (sbinfo->max_inodes != -1)
> seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes);
>
> - hpage_size /= 1024;
> - mod = 'K';
> - if (hpage_size >= 1024) {
> - hpage_size /= 1024;
> + if (hpage_size >= SZ_1M) {
> + hpage_size /= SZ_1M;
> mod = 'M';
> + } else {
> + hpage_size /= SZ_1K;
> + mod = 'K';
> }
> seq_printf(m, ",pagesize=%lu%c", hpage_size, mod);
> if (spool) {
>
Looks correct but I am not convinced the old code was that complicated
to understand.
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hugetlbfs: rework calculation code of Hugepage size in hugetlbfs_show_options()
2021-02-01 10:56 ` David Hildenbrand
@ 2021-02-01 11:19 ` Miaohe Lin
0 siblings, 0 replies; 3+ messages in thread
From: Miaohe Lin @ 2021-02-01 11:19 UTC (permalink / raw)
To: David Hildenbrand; +Cc: linux-mm, linux-kernel, akpm, mike.kravetz
Hi:
On 2021/2/1 18:56, David Hildenbrand wrote:
> On 01.02.21 09:23, Miaohe Lin wrote:
>> Rework calculation code of the Hugepage size to make it more readable and
>> straightforward.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>> fs/hugetlbfs/inode.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
>> index 3a08fbae3b53..1be18de4b537 100644
>> --- a/fs/hugetlbfs/inode.c
>> +++ b/fs/hugetlbfs/inode.c
>> @@ -1014,11 +1014,12 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root)
>> if (sbinfo->max_inodes != -1)
>> seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes);
>> - hpage_size /= 1024;
>> - mod = 'K';
>> - if (hpage_size >= 1024) {
>> - hpage_size /= 1024;
>> + if (hpage_size >= SZ_1M) {
>> + hpage_size /= SZ_1M;
>> mod = 'M';
>> + } else {
>> + hpage_size /= SZ_1K;
>> + mod = 'K';
>> }
>> seq_printf(m, ",pagesize=%lu%c", hpage_size, mod);
>> if (spool) {
>>
>
> Looks correct but I am not convinced the old code was that complicated to understand.
>
The old code is not complicated but I think it may be better to use macro instead of well-known "magic number".
Many thanks for review.:)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-01 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 8:23 [PATCH] hugetlbfs: rework calculation code of Hugepage size in hugetlbfs_show_options() Miaohe Lin
2021-02-01 10:56 ` David Hildenbrand
2021-02-01 11:19 ` Miaohe Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).