* [PATCH v2] mm/hugetlb: Remove unnecessary VM_BUG_ON_PAGE on putback_active_hugepage()
@ 2021-02-09 7:11 Miaohe Lin
2021-02-09 18:18 ` Mike Kravetz
2021-02-11 8:12 ` Oscar Salvador
0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2021-02-09 7:11 UTC (permalink / raw)
To: akpm, mike.kravetz; +Cc: linux-mm, linux-kernel, linmiaohe
All callers know they are operating on a hugetlb head page. So this
VM_BUG_ON_PAGE can not catch anything useful.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/hugetlb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 06719fdf9fd6..cfa06fd1b8d7 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -5577,7 +5577,6 @@ bool isolate_huge_page(struct page *page, struct list_head *list)
void putback_active_hugepage(struct page *page)
{
- VM_BUG_ON_PAGE(!PageHead(page), page);
spin_lock(&hugetlb_lock);
SetHPageMigratable(page);
list_move_tail(&page->lru, &(page_hstate(page))->hugepage_activelist);
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm/hugetlb: Remove unnecessary VM_BUG_ON_PAGE on putback_active_hugepage()
2021-02-09 7:11 [PATCH v2] mm/hugetlb: Remove unnecessary VM_BUG_ON_PAGE on putback_active_hugepage() Miaohe Lin
@ 2021-02-09 18:18 ` Mike Kravetz
2021-02-11 8:12 ` Oscar Salvador
1 sibling, 0 replies; 3+ messages in thread
From: Mike Kravetz @ 2021-02-09 18:18 UTC (permalink / raw)
To: Miaohe Lin, akpm; +Cc: linux-mm, linux-kernel
On 2/8/21 11:11 PM, Miaohe Lin wrote:
> All callers know they are operating on a hugetlb head page. So this
> VM_BUG_ON_PAGE can not catch anything useful.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/hugetlb.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 06719fdf9fd6..cfa06fd1b8d7 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5577,7 +5577,6 @@ bool isolate_huge_page(struct page *page, struct list_head *list)
>
> void putback_active_hugepage(struct page *page)
> {
> - VM_BUG_ON_PAGE(!PageHead(page), page);
> spin_lock(&hugetlb_lock);
> SetHPageMigratable(page);
> list_move_tail(&page->lru, &(page_hstate(page))->hugepage_activelist);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm/hugetlb: Remove unnecessary VM_BUG_ON_PAGE on putback_active_hugepage()
2021-02-09 7:11 [PATCH v2] mm/hugetlb: Remove unnecessary VM_BUG_ON_PAGE on putback_active_hugepage() Miaohe Lin
2021-02-09 18:18 ` Mike Kravetz
@ 2021-02-11 8:12 ` Oscar Salvador
1 sibling, 0 replies; 3+ messages in thread
From: Oscar Salvador @ 2021-02-11 8:12 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, mike.kravetz, linux-mm, linux-kernel
On Tue, Feb 09, 2021 at 02:11:51AM -0500, Miaohe Lin wrote:
> All callers know they are operating on a hugetlb head page. So this
> VM_BUG_ON_PAGE can not catch anything useful.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/hugetlb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 06719fdf9fd6..cfa06fd1b8d7 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5577,7 +5577,6 @@ bool isolate_huge_page(struct page *page, struct list_head *list)
>
> void putback_active_hugepage(struct page *page)
> {
> - VM_BUG_ON_PAGE(!PageHead(page), page);
> spin_lock(&hugetlb_lock);
> SetHPageMigratable(page);
> list_move_tail(&page->lru, &(page_hstate(page))->hugepage_activelist);
> --
> 2.19.1
>
>
--
Oscar Salvador
SUSE L3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-11 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 7:11 [PATCH v2] mm/hugetlb: Remove unnecessary VM_BUG_ON_PAGE on putback_active_hugepage() Miaohe Lin
2021-02-09 18:18 ` Mike Kravetz
2021-02-11 8:12 ` Oscar Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).