From: Timur Tabi <timur@kernel.org>
To: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>,
akpm@linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>,
roman.fietze@magna.com, Kees Cook <keescook@chromium.org>,
John Ogness <john.ogness@linutronix.de>,
akinobu.mita@gmail.com, glider@google.com,
Andrey Konovalov <andreyknvl@google.com>,
Marco Elver <elver@google.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 0/3][RESEND] add support for never printing hashed addresses
Date: Tue, 9 Feb 2021 23:18:11 -0600 [thread overview]
Message-ID: <20210210051814.845713-1-timur@kernel.org> (raw)
[accidentally sent from the wrong email address, so resending]
[The list of email addresses on CC: is getting quite lengthy,
so I hope I've included everyone.]
Although hashing addresses printed via printk does make the
kernel more secure, it interferes with debugging, especially
with some functions like print_hex_dump() which always uses
hashed addresses.
To avoid having to choose between %p and %px, it's easier to
add a kernel command line that treats all %p as %px. This
encourages developers to use %p more without making debugging
more difficult.
Patches #1 and #2 upgrade the kselftest framework so that
it can report on tests that were skipped outright. This
is needed for the test_printf module which will now skip
%p hashing tests if hashing is disabled.
Patch #2 upgrades the printf library to check the command
line. It also updates test_printf().
Timur Tabi (3):
lib/test_printf: use KSTM_MODULE_GLOBALS macro
kselftest: add support for skipped tests
[v2] lib/vsprintf: make-printk-non-secret printks all addresses as
unhashed
.../admin-guide/kernel-parameters.txt | 15 +++++++
lib/test_printf.c | 12 +++++-
lib/vsprintf.c | 40 ++++++++++++++++++-
tools/testing/selftests/kselftest_module.h | 18 ++++++---
4 files changed, 75 insertions(+), 10 deletions(-)
--
2.25.1
next reply other threads:[~2021-02-10 5:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 5:18 Timur Tabi [this message]
2021-02-10 5:18 ` [PATCH 1/3] lib/test_printf: use KSTM_MODULE_GLOBALS macro Timur Tabi
2021-02-10 5:21 ` Timur Tabi
2021-02-10 13:14 ` Petr Mladek
2021-02-10 5:18 ` [PATCH 2/3] kselftest: add support for skipped tests Timur Tabi
2021-02-10 5:18 ` [PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Timur Tabi
2021-02-10 11:03 ` Vlastimil Babka
2021-02-10 13:41 ` Petr Mladek
2021-02-10 17:27 ` Timur Tabi
2021-02-12 11:52 ` Petr Mladek
2021-02-10 11:11 ` [PATCH 0/3][RESEND] add support for never printing hashed addresses Marco Elver
2021-02-10 19:03 ` Timur Tabi
2021-02-10 11:47 ` Andy Shevchenko
2021-02-10 16:57 ` Timur Tabi
2021-02-10 15:46 ` Tetsuo Handa
2021-02-10 16:18 ` Steven Rostedt
2021-02-10 16:39 ` Tetsuo Handa
2021-02-10 16:46 ` Steven Rostedt
2021-02-10 17:07 ` Tetsuo Handa
2021-02-10 17:29 ` Steven Rostedt
2021-02-10 17:21 ` Timur Tabi
2021-02-10 16:54 ` Andy Shevchenko
2021-02-10 17:41 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210051814.845713-1-timur@kernel.org \
--to=timur@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pavel@ucw.cz \
--cc=pmladek@suse.com \
--cc=roman.fietze@magna.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).