* [PATCH] mm/huge_memory.c: Remove unnecessary local variable ret2
@ 2021-02-10 7:24 Miaohe Lin
2021-03-08 10:36 ` Miaohe Lin
0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2021-02-10 7:24 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe
There is no need to use a new local variable ret2 to get the return value
of handle_userfault(). Use ret directly to make code more succinct.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/huge_memory.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 395c75111d33..caf552834dbb 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -624,14 +624,12 @@ static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf,
/* Deliver the page fault to userland */
if (userfaultfd_missing(vma)) {
- vm_fault_t ret2;
-
spin_unlock(vmf->ptl);
put_page(page);
pte_free(vma->vm_mm, pgtable);
- ret2 = handle_userfault(vmf, VM_UFFD_MISSING);
- VM_BUG_ON(ret2 & VM_FAULT_FALLBACK);
- return ret2;
+ ret = handle_userfault(vmf, VM_UFFD_MISSING);
+ VM_BUG_ON(ret & VM_FAULT_FALLBACK);
+ return ret;
}
entry = mk_huge_pmd(page, vma->vm_page_prot);
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/huge_memory.c: Remove unnecessary local variable ret2
2021-02-10 7:24 [PATCH] mm/huge_memory.c: Remove unnecessary local variable ret2 Miaohe Lin
@ 2021-03-08 10:36 ` Miaohe Lin
0 siblings, 0 replies; 2+ messages in thread
From: Miaohe Lin @ 2021-03-08 10:36 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel
Hi:
On 2021/2/10 15:24, Miaohe Lin wrote:
> There is no need to use a new local variable ret2 to get the return value
> of handle_userfault(). Use ret directly to make code more succinct.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
friendly ping in case it's forgotten. :)
> ---
> mm/huge_memory.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 395c75111d33..caf552834dbb 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -624,14 +624,12 @@ static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf,
>
> /* Deliver the page fault to userland */
> if (userfaultfd_missing(vma)) {
> - vm_fault_t ret2;
> -
> spin_unlock(vmf->ptl);
> put_page(page);
> pte_free(vma->vm_mm, pgtable);
> - ret2 = handle_userfault(vmf, VM_UFFD_MISSING);
> - VM_BUG_ON(ret2 & VM_FAULT_FALLBACK);
> - return ret2;
> + ret = handle_userfault(vmf, VM_UFFD_MISSING);
> + VM_BUG_ON(ret & VM_FAULT_FALLBACK);
> + return ret;
> }
>
> entry = mk_huge_pmd(page, vma->vm_page_prot);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-08 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 7:24 [PATCH] mm/huge_memory.c: Remove unnecessary local variable ret2 Miaohe Lin
2021-03-08 10:36 ` Miaohe Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).