From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
VlastimilBabkavbabka@suse.cz, pasha.tatashin@soleen.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v2 6/7] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
Date: Mon, 1 Mar 2021 11:07:38 +0100 [thread overview]
Message-ID: <20210301100737.GB32425@linux> (raw)
In-Reply-To: <de1e2213-7dea-da52-607b-d4d718a3e04e@redhat.com>
On Mon, Mar 01, 2021 at 09:45:07AM +0100, David Hildenbrand wrote:
> Take your config and set
> X86_5LEVEL=n
> (because it enforces SPARSEMEM_VMEMMAP)
> and
> SPARSEMEM_VMEMMAP=n
>
> When compiling, you'll end up with a config like
> CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y
> # CONFIG_SPARSEMEM_VMEMMAP is not set
I see
>
> Yet, with your patch you would get
>
> ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE=y
>
> And it would not get fenced off in the code, right?
>
>
> I think you either have to check (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP)) in
> addition in your code, or enforce it differently. Like
>
>
> config MHP_MEMMAP_ON_MEMORY
> depends on SPARSEMEM_VMEMMAP && ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> bool
>
>
> Then you can simplify the arch Kconfig settings, removing the sparesemem
> dependency there.
Yes, will do it this way.
Thanks!
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-03-01 10:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 13:38 [PATCH v2 0/7] Allocate memmap from hotadded memory (per device) Oscar Salvador
2021-02-09 13:38 ` [PATCH v2 1/7] mm,memory_hotplug: Allocate memmap from the added memory range Oscar Salvador
2021-02-25 18:58 ` David Hildenbrand
2021-02-28 18:50 ` Oscar Salvador
2021-03-01 8:30 ` David Hildenbrand
2021-03-01 8:32 ` David Hildenbrand
2021-02-09 13:38 ` [PATCH v2 2/7] acpi,memhotplug: Enable MHP_MEMMAP_ON_MEMORY when supported Oscar Salvador
2021-02-09 13:38 ` [PATCH v2 3/7] mm,memory_hotplug: Add kernel boot option to enable memmap_on_memory Oscar Salvador
2021-02-25 18:25 ` David Hildenbrand
2021-02-26 12:14 ` Oscar Salvador
2021-03-01 8:27 ` David Hildenbrand
2021-02-09 13:38 ` [PATCH v2 4/7] mm,memory_hotplug: Enforce struct page size to be multiple of PMD Oscar Salvador
2021-02-25 18:26 ` David Hildenbrand
2021-02-26 12:06 ` Oscar Salvador
2021-03-01 10:06 ` Oscar Salvador
2021-03-01 10:24 ` David Hildenbrand
2021-02-09 13:38 ` [PATCH v2 5/7] mm,memory_hotplug: Enforce pageblock alignment when memmap_on_memory Oscar Salvador
2021-02-25 18:27 ` David Hildenbrand
2021-02-26 12:06 ` Oscar Salvador
2021-02-09 13:38 ` [PATCH v2 6/7] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Oscar Salvador
2021-02-25 18:29 ` David Hildenbrand
2021-02-26 12:04 ` Oscar Salvador
2021-03-01 8:45 ` David Hildenbrand
2021-03-01 10:07 ` Oscar Salvador [this message]
2021-02-09 13:38 ` [PATCH v2 7/7] arm64/Kconfig: " Oscar Salvador
2021-02-25 18:29 ` David Hildenbrand
2021-02-26 12:10 ` Oscar Salvador
2021-02-17 10:18 ` [PATCH v2 0/7] Allocate memmap from hotadded memory (per device) Oscar Salvador
2021-02-22 11:15 ` Oscar Salvador
2021-02-22 11:28 ` David Hildenbrand
2021-02-23 7:48 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301100737.GB32425@linux \
--to=osalvador@suse.de \
--cc=VlastimilBabkavbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).