* [PATCH v2] mm/hugetlb: remove redundant reservation check condition in alloc_huge_page()
@ 2021-03-01 10:47 Miaohe Lin
0 siblings, 0 replies; only message in thread
From: Miaohe Lin @ 2021-03-01 10:47 UTC (permalink / raw)
To: akpm, mike.kravetz; +Cc: linux-mm, linux-kernel, linmiaohe
vma_resv_map(vma) checks if a reserve map is associated with the vma. The
routine vma_needs_reservation() will check vma_resv_map(vma) and return 1
if no reserv map is present. map_chg is set to the return value of
vma_needs_reservation(). Therefore, !vma_resv_map(vma) is redundant in the
expression:
map_chg || avoid_reserve || !vma_resv_map(vma);
Remove the redundant check.
[Thanks Mike Kravetz for reshaping this commit message!]
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 60c67eb016f7..060005b868cf 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2314,7 +2314,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma,
/* If this allocation is not consuming a reservation, charge it now.
*/
- deferred_reserve = map_chg || avoid_reserve || !vma_resv_map(vma);
+ deferred_reserve = map_chg || avoid_reserve;
if (deferred_reserve) {
ret = hugetlb_cgroup_charge_cgroup_rsvd(
idx, pages_per_huge_page(h), &h_cg);
--
2.19.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-01 10:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 10:47 [PATCH v2] mm/hugetlb: remove redundant reservation check condition in alloc_huge_page() Miaohe Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).