* [PATCH] mm/oom_kill: fix wild pointer in out_of_memory
@ 2021-03-13 4:23 Jiang Biao
0 siblings, 0 replies; only message in thread
From: Jiang Biao @ 2021-03-13 4:23 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, robinlai, benbjiang
From: Bin Lai <robinlai@tencent.com>
From: Bin Lai <robinlai@tencent.com>
The oc->chosen is used by oom implementation, and the caller does
not initialize this variable. If the tasks of memcg are all unkillable,
oom_evaluate_task cann't choose any task, and the oc->chosen will be
a wild pointer. So we should initialize oc->chosen before calling
oom_evaluate_task.
Signed-off-by: Bin Lai <robinlai@tencent.com>
Reviewed-by: Jiang Biao <benbjiang@tencent.com>
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 9efaf43..0658a30 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -366,6 +366,7 @@ static int oom_evaluate_task(struct task_struct *task, void *arg)
static void select_bad_process(struct oom_control *oc)
{
oc->chosen_points = LONG_MIN;
+ oc->chosen = NULL;
if (is_memcg_oom(oc))
mem_cgroup_scan_tasks(oc->memcg, oom_evaluate_task, oc);
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-13 4:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 4:23 [PATCH] mm/oom_kill: fix wild pointer in out_of_memory Jiang Biao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).