linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jarvis Jiang <jarvis.w.jiang@gmail.com>
Cc: davem@davemloft.net, rppt@linux.ibm.com,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-mm@kvack.org, cchen50@lenovo.com,
	mpearson@lenovo.com
Subject: Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem
Date: Tue, 16 Mar 2021 14:37:56 -0700	[thread overview]
Message-ID: <20210316143756.45ef6d91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210316124237.3469-1-jarvis.w.jiang@gmail.com>

On Tue, 16 Mar 2021 05:42:37 -0700 Jarvis Jiang wrote:
>  drivers/bus/mhi/devices/mhi_netdev.c          | 1830 +++++++++++++

There's already a drivers/net/mhi/

Please make sure the drivers live in their respective subsystem.

Virtio drivers don't sit under drivers/virtio, and most certainly not
under drivers/bus/virtio...

>  drivers/bus/mhi/devices/mhi_satellite.c       | 1155 +++++++++
>  drivers/bus/mhi/devices/mhi_uci.c             |  802 ++++++

Ugh, can you clarify what's the source of this code dump and if you're
coordinating with others working on Qualcomm drivers?


  parent reply	other threads:[~2021-03-16 21:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210316124237.3469-1-jarvis.w.jiang@gmail.com>
2021-03-16 13:30 ` [PATCH] Add MHI bus support and driver for T99W175 5G modem Mike Rapoport
2021-03-17  9:37   ` 蒋威
2021-03-16 21:37 ` Jakub Kicinski [this message]
2021-03-17 10:09   ` 蒋威
2021-03-18  8:45 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210316143756.45ef6d91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cchen50@lenovo.com \
    --cc=davem@davemloft.net \
    --cc=jarvis.w.jiang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpearson@lenovo.com \
    --cc=netdev@vger.kernel.org \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).