linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 7236/7588] mm/util.c:999:2: error: statement requires expression of scalar type ('void' invalid)
@ 2021-03-29  7:21 kernel test robot
  2021-03-30  0:38 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-03-29  7:21 UTC (permalink / raw)
  To: Joe Perches
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List,
	Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 8985 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   931294922e65a23e1aad6398b9ae02df74044679
commit: d1f75d5ddea82b2c610d194d253b4d4ecdaa6be3 [7236/7588] mm/util.c: reduce mem_dump_obj() object size
config: riscv-randconfig-r034-20210328 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 821547cabb5819ed42245376a9afcd11cdee5ddd)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d1f75d5ddea82b2c610d194d253b4d4ecdaa6be3
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout d1f75d5ddea82b2c610d194d253b4d4ecdaa6be3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/riscv/include/asm/mmio.h:89:76: note: expanded from macro 'readl_cpu'
   #define readl_cpu(c)            ({ u32 __r = le32_to_cpu((__force __le32)__raw_readl(c)); __r; })
                                                                                        ^
   include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__le32_to_cpu'
   #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
                                                     ^
   In file included from mm/util.c:13:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:26:
   In file included from include/linux/kernel_stat.h:9:
   In file included from include/linux/interrupt.h:11:
   In file included from include/linux/hardirq.h:10:
   In file included from ./arch/riscv/include/generated/asm/hardirq.h:1:
   In file included from include/asm-generic/hardirq.h:17:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/riscv/include/asm/io.h:149:
   include/asm-generic/io.h:580:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           outb(value, addr);
           ^~~~~~~~~~~~~~~~~
   arch/riscv/include/asm/io.h:59:68: note: expanded from macro 'outb'
   #define outb(v,c)       ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
                                                                 ~~~~~~~~~~ ^
   arch/riscv/include/asm/mmio.h:91:52: note: expanded from macro 'writeb_cpu'
   #define writeb_cpu(v, c)        ((void)__raw_writeb((v), (c)))
                                                             ^
   In file included from mm/util.c:13:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:26:
   In file included from include/linux/kernel_stat.h:9:
   In file included from include/linux/interrupt.h:11:
   In file included from include/linux/hardirq.h:10:
   In file included from ./arch/riscv/include/generated/asm/hardirq.h:1:
   In file included from include/asm-generic/hardirq.h:17:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/riscv/include/asm/io.h:149:
   include/asm-generic/io.h:588:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           outw(value, addr);
           ^~~~~~~~~~~~~~~~~
   arch/riscv/include/asm/io.h:60:68: note: expanded from macro 'outw'
   #define outw(v,c)       ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
                                                                 ~~~~~~~~~~ ^
   arch/riscv/include/asm/mmio.h:92:76: note: expanded from macro 'writew_cpu'
   #define writew_cpu(v, c)        ((void)__raw_writew((__force u16)cpu_to_le16(v), (c)))
                                                                                     ^
   In file included from mm/util.c:13:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:26:
   In file included from include/linux/kernel_stat.h:9:
   In file included from include/linux/interrupt.h:11:
   In file included from include/linux/hardirq.h:10:
   In file included from ./arch/riscv/include/generated/asm/hardirq.h:1:
   In file included from include/asm-generic/hardirq.h:17:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/riscv/include/asm/io.h:149:
   include/asm-generic/io.h:596:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           outl(value, addr);
           ^~~~~~~~~~~~~~~~~
   arch/riscv/include/asm/io.h:61:68: note: expanded from macro 'outl'
   #define outl(v,c)       ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
                                                                 ~~~~~~~~~~ ^
   arch/riscv/include/asm/mmio.h:93:76: note: expanded from macro 'writel_cpu'
   #define writel_cpu(v, c)        ((void)__raw_writel((__force u32)cpu_to_le32(v), (c)))
                                                                                     ^
   In file included from mm/util.c:13:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:26:
   In file included from include/linux/kernel_stat.h:9:
   In file included from include/linux/interrupt.h:11:
   In file included from include/linux/hardirq.h:10:
   In file included from ./arch/riscv/include/generated/asm/hardirq.h:1:
   In file included from include/asm-generic/hardirq.h:17:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/riscv/include/asm/io.h:149:
   include/asm-generic/io.h:1005:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
           return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
                                                     ~~~~~~~~~~ ^
   In file included from mm/util.c:29:
   mm/internal.h:454:8: error: use of undeclared identifier 'max_mapnr'
                   if (!pfn_valid(pfn))
                        ^
   arch/riscv/include/asm/page.h:130:62: note: expanded from macro 'pfn_valid'
           (((pfn) >= ARCH_PFN_OFFSET) && (((pfn) - ARCH_PFN_OFFSET) < max_mapnr))
                                                                       ^
   mm/util.c:999:6: error: use of undeclared identifier 'max_mapnr'
           if (virt_addr_valid(object))
               ^
   arch/riscv/include/asm/page.h:137:43: note: expanded from macro 'virt_addr_valid'
           (unsigned long)(_addr) >= PAGE_OFFSET && pfn_valid(virt_to_pfn(_addr)); \
                                                    ^
   arch/riscv/include/asm/page.h:130:62: note: expanded from macro 'pfn_valid'
           (((pfn) >= ARCH_PFN_OFFSET) && (((pfn) - ARCH_PFN_OFFSET) < max_mapnr))
                                                                       ^
>> mm/util.c:999:2: error: statement requires expression of scalar type ('void' invalid)
           if (virt_addr_valid(object))
           ^   ~~~~~~~~~~~~~~~~~~~~~~~
   7 warnings and 3 errors generated.


vim +999 mm/util.c

   975	
   976	/**
   977	 * mem_dump_obj - Print available provenance information
   978	 * @object: object for which to find provenance information.
   979	 *
   980	 * This function uses pr_cont(), so that the caller is expected to have
   981	 * printed out whatever preamble is appropriate.  The provenance information
   982	 * depends on the type of object and on how much debugging is enabled.
   983	 * For example, for a slab-cache object, the slab name is printed, and,
   984	 * if available, the return address and stack trace from the allocation
   985	 * and last free path of that object.
   986	 */
   987	void mem_dump_obj(void *object)
   988	{
   989		const char *type;
   990	
   991		if (kmem_valid_obj(object)) {
   992			kmem_dump_obj(object);
   993			return;
   994		}
   995	
   996		if (vmalloc_dump_obj(object))
   997			return;
   998	
 > 999		if (virt_addr_valid(object))

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30926 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [linux-next:master 7236/7588] mm/util.c:999:2: error: statement requires expression of scalar type ('void' invalid)
  2021-03-29  7:21 [linux-next:master 7236/7588] mm/util.c:999:2: error: statement requires expression of scalar type ('void' invalid) kernel test robot
@ 2021-03-30  0:38 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2021-03-30  0:38 UTC (permalink / raw)
  To: kernel test robot
  Cc: Joe Perches, kbuild-all, clang-built-linux,
	Linux Memory Management List, Paul Walmsley, Palmer Dabbelt,
	Albert Ou

On Mon, 29 Mar 2021 15:21:47 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   931294922e65a23e1aad6398b9ae02df74044679
> commit: d1f75d5ddea82b2c610d194d253b4d4ecdaa6be3 [7236/7588] mm/util.c: reduce mem_dump_obj() object size
> config: riscv-randconfig-r034-20210328 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 821547cabb5819ed42245376a9afcd11cdee5ddd)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install riscv cross compiling tool for clang build
>         # apt-get install binutils-riscv64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d1f75d5ddea82b2c610d194d253b4d4ecdaa6be3
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout d1f75d5ddea82b2c610d194d253b4d4ecdaa6be3
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 
> 
> ...
>
>                                                      ~~~~~~~~~~ ^
>    In file included from mm/util.c:29:
>    mm/internal.h:454:8: error: use of undeclared identifier 'max_mapnr'
>                    if (!pfn_valid(pfn))
>                         ^
>    arch/riscv/include/asm/page.h:130:62: note: expanded from macro 'pfn_valid'
>            (((pfn) >= ARCH_PFN_OFFSET) && (((pfn) - ARCH_PFN_OFFSET) < max_mapnr))
>                                                                        ^
>    mm/util.c:999:6: error: use of undeclared identifier 'max_mapnr'
>            if (virt_addr_valid(object))
>                ^
>    arch/riscv/include/asm/page.h:137:43: note: expanded from macro 'virt_addr_valid'
>            (unsigned long)(_addr) >= PAGE_OFFSET && pfn_valid(virt_to_pfn(_addr)); \
>                                                     ^
>    arch/riscv/include/asm/page.h:130:62: note: expanded from macro 'pfn_valid'
>            (((pfn) >= ARCH_PFN_OFFSET) && (((pfn) - ARCH_PFN_OFFSET) < max_mapnr))
>                                                                        ^
> >> mm/util.c:999:2: error: statement requires expression of scalar type ('void' invalid)
>            if (virt_addr_valid(object))
>            ^   ~~~~~~~~~~~~~~~~~~~~~~~
>    7 warnings and 3 errors generated.

"mm/util.c: reduce mem_dump_obj() object size" can't be the cause of this.

It appears that riscv doesn't handle CONFIG_NEED_MULTIPLE_NODES=y.  Its
pfn_valid() (and hence virt_addr_valid()) implementations require that
max_mapnr be defined and implemented.  But with
CONFIG_NEED_MULTIPLE_NODES=y, that is not the case.

Probably riscv needs some Kconfig fix to disallow this config combination.


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-30  0:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29  7:21 [linux-next:master 7236/7588] mm/util.c:999:2: error: statement requires expression of scalar type ('void' invalid) kernel test robot
2021-03-30  0:38 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).