linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 12235/13394] drivers/hwmon/pmbus/fsp-3y.c:150:26: sparse: sparse: symbol 'fsp3y_info' was not declared. Should it be static?
@ 2021-04-16 13:50 kernel test robot
  2021-04-16 13:50 ` [RFC PATCH linux-next] hwmon: fsp3y_info[] can be static kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-04-16 13:50 UTC (permalink / raw)
  To: Václav Kubernát
  Cc: kbuild-all, Linux Memory Management List, Guenter Roeck,
	Jean Delvare, linux-hwmon, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   18250b538735142307082e4e99e3ae5c12d44013
commit: fdf70b5de6f3edfc8561d31a6b478592fae4177f [12235/13394] hwmon: Add driver for fsp-3y PSUs and PDUs
config: i386-randconfig-s032-20210416 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-280-g2cd6d34e-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fdf70b5de6f3edfc8561d31a6b478592fae4177f
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout fdf70b5de6f3edfc8561d31a6b478592fae4177f
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/hwmon/pmbus/fsp-3y.c:150:26: sparse: sparse: symbol 'fsp3y_info' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34240 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH linux-next] hwmon: fsp3y_info[] can be static
  2021-04-16 13:50 [linux-next:master 12235/13394] drivers/hwmon/pmbus/fsp-3y.c:150:26: sparse: sparse: symbol 'fsp3y_info' was not declared. Should it be static? kernel test robot
@ 2021-04-16 13:50 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-16 13:50 UTC (permalink / raw)
  To: Václav Kubernát
  Cc: kbuild-all, Linux Memory Management List, Guenter Roeck,
	Jean Delvare, linux-hwmon, linux-kernel


Fixes: fdf70b5de6f3 ("hwmon: Add driver for fsp-3y PSUs and PDUs")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 fsp-3y.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/pmbus/fsp-3y.c b/drivers/hwmon/pmbus/fsp-3y.c
index 3ff4bace9a85f..284b73aaed467 100644
--- a/drivers/hwmon/pmbus/fsp-3y.c
+++ b/drivers/hwmon/pmbus/fsp-3y.c
@@ -147,7 +147,7 @@ static int fsp3y_read_word_data(struct i2c_client *client, int page, int phase,
 	return i2c_smbus_read_word_data(client, reg);
 }
 
-struct pmbus_driver_info fsp3y_info[] = {
+static struct pmbus_driver_info fsp3y_info[] = {
 	[ym2151e] = {
 		.pages = 2,
 		.func[YM2151_PAGE_12V_LOG] =


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-16 13:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 13:50 [linux-next:master 12235/13394] drivers/hwmon/pmbus/fsp-3y.c:150:26: sparse: sparse: symbol 'fsp3y_info' was not declared. Should it be static? kernel test robot
2021-04-16 13:50 ` [RFC PATCH linux-next] hwmon: fsp3y_info[] can be static kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).