From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
akpm@linux-foundation.org, iamjoonsoo.kim@lge.com,
rientjes@google.com, penberg@kernel.org, cl@linux.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
naresh.kamboju@linaro.org, clang-built-linux@googlegroups.com,
linux-next@vger.kernel.org, ndesaulniers@google.com,
lkft-triage@lists.linaro.org, sfr@canb.auug.org.au,
arnd@arndb.de, Marco Elver <elver@google.com>
Subject: Re: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time
Date: Tue, 18 May 2021 09:38:59 +0900 [thread overview]
Message-ID: <20210518003859.GC80297@hyeyoo> (raw)
In-Reply-To: <YKC9CeAfw3aBmHTU@archlinux-ax161>
On Sat, May 15, 2021 at 11:34:49PM -0700, Nathan Chancellor wrote:
> This should work I think:
compiled well with clang-10.0.1, clang-11.0.0,
and gcc-10.2.0 with x86_64 default config.
is the condition CONFIG_CLANG_VERSION > 110000,
not including 110000 it self?
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index 9d316aac0aba..1b653266f2aa 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -413,7 +413,7 @@ static __always_inline unsigned int __kmalloc_index(size_t size,
> if (size <= 16 * 1024 * 1024) return 24;
> if (size <= 32 * 1024 * 1024) return 25;
>
> - if (size_is_constant)
> + if ((IS_ENABLED(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION > 110000) && size_is_constant)
> BUILD_BUG_ON_MSG(1, "unexpected size in kmalloc_index()");
> else
> BUG();
next prev parent reply other threads:[~2021-05-18 0:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 17:34 [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Hyeonggon Yoo
2021-05-11 17:38 ` Hyeonggon Yoo
2021-05-11 18:08 ` Vlastimil Babka
2021-05-13 2:52 ` Andrew Morton
2021-05-13 3:12 ` Hyeonggon Yoo
2021-05-13 3:40 ` Andrew Morton
2021-05-13 6:28 ` Hyeonggon Yoo
2021-05-13 8:46 ` Marco Elver
2021-05-13 8:51 ` Vlastimil Babka
2021-05-13 10:31 ` Marco Elver
2021-05-13 11:37 ` Vlastimil Babka
2021-05-13 12:08 ` Hyeonggon Yoo
2021-05-13 12:10 ` Hyeonggon Yoo
2021-05-13 12:03 ` Hyeonggon Yoo
2021-05-13 12:29 ` Marco Elver
2021-05-13 12:38 ` Hyeonggon Yoo
2021-05-13 13:08 ` Hyeonggon Yoo
2021-05-13 12:44 ` [PATCH] kfence: test: fix for "mm, slub: change run-time assertion in kmalloc_index() to compile-time" Marco Elver
2021-05-15 21:09 ` [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Hyeonggon Yoo
2021-05-15 21:24 ` Vlastimil Babka
2021-05-15 21:56 ` Hyeonggon Yoo
2021-05-16 6:34 ` Nathan Chancellor
2021-05-18 0:38 ` Hyeonggon Yoo [this message]
2021-05-18 0:43 ` Nathan Chancellor
2021-05-18 1:53 ` Hyeonggon Yoo
2021-05-18 9:28 ` Vlastimil Babka
2021-05-18 11:18 ` Hyeonggon Yoo
2021-05-18 11:34 ` Vlastimil Babka
2021-05-19 5:45 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518003859.GC80297@hyeyoo \
--to=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=clang-built-linux@googlegroups.com \
--cc=elver@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).