linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH STABLE 4.4-5.3] mm, vmstat: drop zone->lock in /proc/pagetypeinfo
@ 2021-05-26 17:46 Stephen Brennan
  2021-05-27  9:15 ` Greg KH
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Stephen Brennan @ 2021-05-26 17:46 UTC (permalink / raw)
  To: stable
  Cc: Stephen Brennan, Andrew Morton, linux-mm, linux-kernel,
	Christoph Lameter, Mel Gorman, Andy Whitcroft, Aruna Ramakrishna,
	Khalid Aziz

Commit 93b3a674485f6a4b8ffff85d1682d5e8b7c51560 upstream

Commit 93b3a674485f ("mm,vmstat: reduce zone->lock holding time by
/proc/pagetypeinfo") upstream caps the number of iterations over each
free_list at 100,000, and also drops the zone->lock in between each
migrate type. Capping the iteration count alters the file contents in
some cases, which means this approach may not be suitable for stable
backports.

However, dropping zone->lock in between migrate types (and, as a result,
page orders) will not change the /proc/pagetypeinfo file contents. It
can significantly reduce the length of time spent with IRQs disabled,
which can prevent missed interrupts or soft lockups which we have
observed on systems with particularly large memory.

Thus, this commit is a modified version of the upstream one which only
drops the lock in between migrate types.

Fixes: 467c996c1e19 ("Print out statistics in relation to fragmentation avoidance to /proc/pagetypeinfo")
Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
Reviewed-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
Reviewed-by: Khalid Aziz <khalid.aziz@oracle.com>
---

mm/vmstat.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index 13b74c4314a7e..663069cf7724a 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1316,6 +1316,9 @@ static void pagetypeinfo_showfree_print(struct seq_file *m,
 			list_for_each(curr, &area->free_list[mtype])
 				freecount++;
 			seq_printf(m, "%6lu ", freecount);
+			spin_unlock_irq(&zone->lock);
+			cond_resched();
+			spin_lock_irq(&zone->lock);
 		}
 		seq_putc(m, '\n');
 	}
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-27  9:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 17:46 [PATCH STABLE 4.4-5.3] mm, vmstat: drop zone->lock in /proc/pagetypeinfo Stephen Brennan
2021-05-27  9:15 ` Greg KH
2021-05-27  9:22 ` Patch "mm, vmstat: drop zone->lock in /proc/pagetypeinfo" has been added to the 4.4-stable tree gregkh
2021-05-27  9:23 ` Patch "mm, vmstat: drop zone->lock in /proc/pagetypeinfo" has been added to the 4.9-stable tree gregkh
2021-05-27  9:23 ` Patch "mm, vmstat: drop zone->lock in /proc/pagetypeinfo" has been added to the 4.14-stable tree gregkh
2021-05-27  9:24 ` Patch "mm, vmstat: drop zone->lock in /proc/pagetypeinfo" has been added to the 4.19-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).