* [linux-next:master 4915/6976] drivers/hwspinlock/sun6i_hwspinlock.c:65:39: sparse: sparse: incorrect type in initializer (different address spaces)
@ 2021-06-03 10:56 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-06-03 10:56 UTC (permalink / raw)
To: Wilken Gottwalt
Cc: kbuild-all, Linux Memory Management List, Bjorn Andersson,
Samuel Holland
[-- Attachment #1: Type: text/plain, Size: 7151 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 3ebdbe7aa5dd825d609c3433c35c13b440a61c52
commit: 3c881e05c814c970e4f9577446a9d3461d134607 [4915/6976] hwspinlock: add sun6i hardware spinlock support
config: sparc-randconfig-s032-20210603 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3c881e05c814c970e4f9577446a9d3461d134607
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 3c881e05c814c970e4f9577446a9d3461d134607
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/hwspinlock/sun6i_hwspinlock.c:65:39: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *lock_addr @@ got void *priv @@
drivers/hwspinlock/sun6i_hwspinlock.c:65:39: sparse: expected void [noderef] __iomem *lock_addr
drivers/hwspinlock/sun6i_hwspinlock.c:65:39: sparse: got void *priv
drivers/hwspinlock/sun6i_hwspinlock.c:72:39: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *lock_addr @@ got void *priv @@
drivers/hwspinlock/sun6i_hwspinlock.c:72:39: sparse: expected void [noderef] __iomem *lock_addr
drivers/hwspinlock/sun6i_hwspinlock.c:72:39: sparse: got void *priv
>> drivers/hwspinlock/sun6i_hwspinlock.c:166:30: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *priv @@ got void [noderef] __iomem * @@
drivers/hwspinlock/sun6i_hwspinlock.c:166:30: sparse: expected void *priv
drivers/hwspinlock/sun6i_hwspinlock.c:166:30: sparse: got void [noderef] __iomem *
vim +65 drivers/hwspinlock/sun6i_hwspinlock.c
62
63 static int sun6i_hwspinlock_trylock(struct hwspinlock *lock)
64 {
> 65 void __iomem *lock_addr = lock->priv;
66
67 return (readl(lock_addr) == SPINLOCK_NOTTAKEN);
68 }
69
70 static void sun6i_hwspinlock_unlock(struct hwspinlock *lock)
71 {
72 void __iomem *lock_addr = lock->priv;
73
74 writel(SPINLOCK_NOTTAKEN, lock_addr);
75 }
76
77 static const struct hwspinlock_ops sun6i_hwspinlock_ops = {
78 .trylock = sun6i_hwspinlock_trylock,
79 .unlock = sun6i_hwspinlock_unlock,
80 };
81
82 static void sun6i_hwspinlock_disable(void *data)
83 {
84 struct sun6i_hwspinlock_data *priv = data;
85
86 debugfs_remove_recursive(priv->debugfs);
87 clk_disable_unprepare(priv->ahb_clk);
88 reset_control_assert(priv->reset);
89 }
90
91 static int sun6i_hwspinlock_probe(struct platform_device *pdev)
92 {
93 struct sun6i_hwspinlock_data *priv;
94 struct hwspinlock *hwlock;
95 void __iomem *io_base;
96 u32 num_banks;
97 int err, i;
98
99 io_base = devm_platform_ioremap_resource(pdev, SPINLOCK_BASE_ID);
100 if (IS_ERR(io_base))
101 return PTR_ERR(io_base);
102
103 priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
104 if (!priv)
105 return -ENOMEM;
106
107 priv->ahb_clk = devm_clk_get(&pdev->dev, "ahb");
108 if (IS_ERR(priv->ahb_clk)) {
109 err = PTR_ERR(priv->ahb_clk);
110 dev_err(&pdev->dev, "unable to get AHB clock (%d)\n", err);
111 return err;
112 }
113
114 priv->reset = devm_reset_control_get(&pdev->dev, "ahb");
115 if (IS_ERR(priv->reset))
116 return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset),
117 "unable to get reset control\n");
118
119 err = reset_control_deassert(priv->reset);
120 if (err) {
121 dev_err(&pdev->dev, "deassert reset control failure (%d)\n", err);
122 return err;
123 }
124
125 err = clk_prepare_enable(priv->ahb_clk);
126 if (err) {
127 dev_err(&pdev->dev, "unable to prepare AHB clk (%d)\n", err);
128 goto clk_fail;
129 }
130
131 /*
132 * bit 28 and 29 represents the hwspinlock setup
133 *
134 * every datasheet (A64, A80, A83T, H3, H5, H6 ...) says the default value is 0x1 and 0x1
135 * to 0x4 represent 32, 64, 128 and 256 locks
136 * but later datasheets (H5, H6) say 00, 01, 10, 11 represent 32, 64, 128 and 256 locks,
137 * but that would mean H5 and H6 have 64 locks, while their datasheets talk about 32 locks
138 * all the time, not a single mentioning of 64 locks
139 * the 0x4 value is also not representable by 2 bits alone, so some datasheets are not
140 * correct
141 * one thing have all in common, default value of the sysstatus register is 0x10000000,
142 * which results in bit 28 being set
143 * this is the reason 0x1 is considered being 32 locks and bit 30 is taken into account
144 * verified on H2+ (datasheet 0x1 = 32 locks) and H5 (datasheet 01 = 64 locks)
145 */
146 num_banks = readl(io_base + SPINLOCK_SYSSTATUS_REG) >> 28;
147 switch (num_banks) {
148 case 1 ... 4:
149 priv->nlocks = 1 << (4 + num_banks);
150 break;
151 default:
152 err = -EINVAL;
153 dev_err(&pdev->dev, "unsupported hwspinlock setup (%d)\n", num_banks);
154 goto bank_fail;
155 }
156
157 priv->bank = devm_kzalloc(&pdev->dev, struct_size(priv->bank, lock, priv->nlocks),
158 GFP_KERNEL);
159 if (!priv->bank) {
160 err = -ENOMEM;
161 goto bank_fail;
162 }
163
164 for (i = 0; i < priv->nlocks; ++i) {
165 hwlock = &priv->bank->lock[i];
> 166 hwlock->priv = io_base + SPINLOCK_LOCK_REGN + sizeof(u32) * i;
167 }
168
169 /* failure of debugfs is considered non-fatal */
170 sun6i_hwspinlock_debugfs_init(priv);
171 if (IS_ERR(priv->debugfs))
172 priv->debugfs = NULL;
173
174 err = devm_add_action_or_reset(&pdev->dev, sun6i_hwspinlock_disable, priv);
175 if (err) {
176 dev_err(&pdev->dev, "failed to add hwspinlock disable action\n");
177 goto bank_fail;
178 }
179
180 platform_set_drvdata(pdev, priv);
181
182 return devm_hwspin_lock_register(&pdev->dev, priv->bank, &sun6i_hwspinlock_ops,
183 SPINLOCK_BASE_ID, priv->nlocks);
184
185 bank_fail:
186 clk_disable_unprepare(priv->ahb_clk);
187 clk_fail:
188 reset_control_assert(priv->reset);
189
190 return err;
191 }
192
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35516 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-03 10:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 10:56 [linux-next:master 4915/6976] drivers/hwspinlock/sun6i_hwspinlock.c:65:39: sparse: sparse: incorrect type in initializer (different address spaces) kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).