linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 186/12612] kernel/trace/trace_events_hist.c:4566:13: warning: stack frame size (1344) exceeds limit (1024) in function 'hist_trigger_print_key'
@ 2021-06-23 18:13 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-06-23 18:13 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List,
	Alex Gaynor, Geoffrey Thomas, Finn Behrens, Adam Bratschi-Kaye,
	Wedson Almeida Filho

[-- Attachment #1: Type: text/plain, Size: 9006 bytes --]

Hi Miguel,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   d61c8b66c84080ecf8f9f4d9272ab4ec78029a59
commit: b1b3e4b16c4801379ba4d9c8807dc78bd0e40f2b [186/12612] kallsyms: Increase maximum kernel symbol length to 512
config: powerpc-randconfig-r004-20210622 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project b259740801d3515810ecc15bf0c24b0d476a1608)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b1b3e4b16c4801379ba4d9c8807dc78bd0e40f2b
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout b1b3e4b16c4801379ba4d9c8807dc78bd0e40f2b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from kernel/trace/trace_events_hist.c:8:
   In file included from include/linux/module.h:12:
   In file included from include/linux/list.h:9:
   In file included from include/linux/kernel.h:11:
   In file included from include/linux/bitops.h:32:
   In file included from arch/powerpc/include/asm/bitops.h:62:
   arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined]
   #define __lwsync()      __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
           ^
   <built-in>:309:9: note: previous definition is here
   #define __lwsync __builtin_ppc_lwsync
           ^
   kernel/trace/trace_events_hist.c:5200:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
           int ret;
               ^
>> kernel/trace/trace_events_hist.c:4566:13: warning: stack frame size (1344) exceeds limit (1024) in function 'hist_trigger_print_key' [-Wframe-larger-than]
   static void hist_trigger_print_key(struct seq_file *m,
               ^
   3 warnings generated.


vim +/hist_trigger_print_key +4566 kernel/trace/trace_events_hist.c

69a0200c2e25d6 Tom Zanussi  2016-03-03  4565  
a3785b7eca8fd4 Tom Zanussi  2019-02-13 @4566  static void hist_trigger_print_key(struct seq_file *m,
a3785b7eca8fd4 Tom Zanussi  2019-02-13  4567  				   struct hist_trigger_data *hist_data,
a3785b7eca8fd4 Tom Zanussi  2019-02-13  4568  				   void *key,
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4569  				   struct tracing_map_elt *elt)
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4570  {
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4571  	struct hist_field *key_field;
c6afad49d127f6 Tom Zanussi  2016-03-03  4572  	char str[KSYM_SYMBOL_LEN];
69a0200c2e25d6 Tom Zanussi  2016-03-03  4573  	bool multiline = false;
85013256cf0162 Tom Zanussi  2017-09-22  4574  	const char *field_name;
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4575  	unsigned int i;
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4576  	u64 uval;
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4577  
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4578  	seq_puts(m, "{ ");
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4579  
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4580  	for_each_hist_key_field(i, hist_data) {
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4581  		key_field = hist_data->fields[i];
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4582  
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4583  		if (i > hist_data->n_vals)
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4584  			seq_puts(m, ", ");
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4585  
85013256cf0162 Tom Zanussi  2017-09-22  4586  		field_name = hist_field_name(key_field, 0);
85013256cf0162 Tom Zanussi  2017-09-22  4587  
0c4a6b4666e8eb Tom Zanussi  2016-03-03  4588  		if (key_field->flags & HIST_FIELD_FL_HEX) {
0c4a6b4666e8eb Tom Zanussi  2016-03-03  4589  			uval = *(u64 *)(key + key_field->offset);
85013256cf0162 Tom Zanussi  2017-09-22  4590  			seq_printf(m, "%s: %llx", field_name, uval);
c6afad49d127f6 Tom Zanussi  2016-03-03  4591  		} else if (key_field->flags & HIST_FIELD_FL_SYM) {
c6afad49d127f6 Tom Zanussi  2016-03-03  4592  			uval = *(u64 *)(key + key_field->offset);
c6afad49d127f6 Tom Zanussi  2016-03-03  4593  			sprint_symbol_no_offset(str, uval);
85013256cf0162 Tom Zanussi  2017-09-22  4594  			seq_printf(m, "%s: [%llx] %-45s", field_name,
85013256cf0162 Tom Zanussi  2017-09-22  4595  				   uval, str);
c6afad49d127f6 Tom Zanussi  2016-03-03  4596  		} else if (key_field->flags & HIST_FIELD_FL_SYM_OFFSET) {
c6afad49d127f6 Tom Zanussi  2016-03-03  4597  			uval = *(u64 *)(key + key_field->offset);
c6afad49d127f6 Tom Zanussi  2016-03-03  4598  			sprint_symbol(str, uval);
85013256cf0162 Tom Zanussi  2017-09-22  4599  			seq_printf(m, "%s: [%llx] %-55s", field_name,
85013256cf0162 Tom Zanussi  2017-09-22  4600  				   uval, str);
6b4827ad028a1a Tom Zanussi  2016-03-03  4601  		} else if (key_field->flags & HIST_FIELD_FL_EXECNAME) {
af6a29bcaf8ff2 Tom Zanussi  2018-01-15  4602  			struct hist_elt_data *elt_data = elt->private_data;
af6a29bcaf8ff2 Tom Zanussi  2018-01-15  4603  			char *comm;
af6a29bcaf8ff2 Tom Zanussi  2018-01-15  4604  
af6a29bcaf8ff2 Tom Zanussi  2018-01-15  4605  			if (WARN_ON_ONCE(!elt_data))
af6a29bcaf8ff2 Tom Zanussi  2018-01-15  4606  				return;
af6a29bcaf8ff2 Tom Zanussi  2018-01-15  4607  
af6a29bcaf8ff2 Tom Zanussi  2018-01-15  4608  			comm = elt_data->comm;
6b4827ad028a1a Tom Zanussi  2016-03-03  4609  
6b4827ad028a1a Tom Zanussi  2016-03-03  4610  			uval = *(u64 *)(key + key_field->offset);
85013256cf0162 Tom Zanussi  2017-09-22  4611  			seq_printf(m, "%s: %-16s[%10llu]", field_name,
85013256cf0162 Tom Zanussi  2017-09-22  4612  				   comm, uval);
316961988b5ec7 Tom Zanussi  2016-03-03  4613  		} else if (key_field->flags & HIST_FIELD_FL_SYSCALL) {
316961988b5ec7 Tom Zanussi  2016-03-03  4614  			const char *syscall_name;
316961988b5ec7 Tom Zanussi  2016-03-03  4615  
316961988b5ec7 Tom Zanussi  2016-03-03  4616  			uval = *(u64 *)(key + key_field->offset);
316961988b5ec7 Tom Zanussi  2016-03-03  4617  			syscall_name = get_syscall_name(uval);
316961988b5ec7 Tom Zanussi  2016-03-03  4618  			if (!syscall_name)
316961988b5ec7 Tom Zanussi  2016-03-03  4619  				syscall_name = "unknown_syscall";
316961988b5ec7 Tom Zanussi  2016-03-03  4620  
85013256cf0162 Tom Zanussi  2017-09-22  4621  			seq_printf(m, "%s: %-30s[%3llu]", field_name,
85013256cf0162 Tom Zanussi  2017-09-22  4622  				   syscall_name, uval);
69a0200c2e25d6 Tom Zanussi  2016-03-03  4623  		} else if (key_field->flags & HIST_FIELD_FL_STACKTRACE) {
69a0200c2e25d6 Tom Zanussi  2016-03-03  4624  			seq_puts(m, "stacktrace:\n");
69a0200c2e25d6 Tom Zanussi  2016-03-03  4625  			hist_trigger_stacktrace_print(m,
69a0200c2e25d6 Tom Zanussi  2016-03-03  4626  						      key + key_field->offset,
69a0200c2e25d6 Tom Zanussi  2016-03-03  4627  						      HIST_STACKTRACE_DEPTH);
69a0200c2e25d6 Tom Zanussi  2016-03-03  4628  			multiline = true;
4b94f5b7b4a5ff Namhyung Kim 2016-03-03  4629  		} else if (key_field->flags & HIST_FIELD_FL_LOG2) {
85013256cf0162 Tom Zanussi  2017-09-22  4630  			seq_printf(m, "%s: ~ 2^%-2llu", field_name,
4b94f5b7b4a5ff Namhyung Kim 2016-03-03  4631  				   *(u64 *)(key + key_field->offset));
0c4a6b4666e8eb Tom Zanussi  2016-03-03  4632  		} else if (key_field->flags & HIST_FIELD_FL_STRING) {
85013256cf0162 Tom Zanussi  2017-09-22  4633  			seq_printf(m, "%s: %-50s", field_name,
76a3b0c8ac344e Tom Zanussi  2016-03-03  4634  				   (char *)(key + key_field->offset));
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4635  		} else {
76a3b0c8ac344e Tom Zanussi  2016-03-03  4636  			uval = *(u64 *)(key + key_field->offset);
85013256cf0162 Tom Zanussi  2017-09-22  4637  			seq_printf(m, "%s: %10llu", field_name, uval);
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4638  		}
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4639  	}
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4640  
69a0200c2e25d6 Tom Zanussi  2016-03-03  4641  	if (!multiline)
69a0200c2e25d6 Tom Zanussi  2016-03-03  4642  		seq_puts(m, " ");
69a0200c2e25d6 Tom Zanussi  2016-03-03  4643  
7ef224d1d0e3a1 Tom Zanussi  2016-03-03  4644  	seq_puts(m, "}");
a3785b7eca8fd4 Tom Zanussi  2019-02-13  4645  }
a3785b7eca8fd4 Tom Zanussi  2019-02-13  4646  

:::::: The code at line 4566 was first introduced by commit
:::::: a3785b7eca8fd45c7c39f2ddfcd67368af30c1b4 tracing: Add hist trigger snapshot() action

:::::: TO: Tom Zanussi <tom.zanussi@linux.intel.com>
:::::: CC: Steven Rostedt (VMware) <rostedt@goodmis.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33120 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-06-23 18:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 18:13 [linux-next:master 186/12612] kernel/trace/trace_events_hist.c:4566:13: warning: stack frame size (1344) exceeds limit (1024) in function 'hist_trigger_print_key' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).