From: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tyler Hicks <tyhicks@linux.microsoft.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm: KSM: fix data type
Date: Fri, 16 Jul 2021 10:42:01 +0600 [thread overview]
Message-ID: <20210716044201.GA210515@asus> (raw)
In-Reply-To: <CA+CK2bCzn8BVOH2pB4=MPyyDN9KeoWRmQ=GYq25R1zDKibuEeg@mail.gmail.com>
On Thu, Jul 15, 2021 at 02:10:33PM -0400, Pavel Tatashin wrote:
> On Thu, Jul 15, 2021 at 2:01 PM Zhansaya Bagdauletkyzy
> <zhansayabagdaulet@gmail.com> wrote:
> >
> > ksm_stable_node_chains_prune_millisecs is declared as int, but in
> > stable__node_chains_prune_millisecs_store(), it can store values up to
> > UINT_MAX. Change the variable type to unsigned int.
> >
> > Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
> > ---
> > mm/ksm.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/mm/ksm.c b/mm/ksm.c
> > index 057d0c245bf4..2e4bd7662e52 100644
> > --- a/mm/ksm.c
> > +++ b/mm/ksm.c
> > @@ -259,7 +259,7 @@ static unsigned long ksm_stable_node_chains;
> > static unsigned long ksm_stable_node_dups;
> >
> > /* Delay in pruning stale stable_node_dups in the stable_node_chains */
> > -static int ksm_stable_node_chains_prune_millisecs = 2000;
> > +static unsigned int ksm_stable_node_chains_prune_millisecs = 2000;
> >
> > /* Maximum number of page slots sharing a stable node */
> > static int ksm_max_page_sharing = 256;
> > @@ -3105,11 +3105,11 @@ stable_node_chains_prune_millisecs_store(struct kobject *kobj,
> > struct kobj_attribute *attr,
> > const char *buf, size_t count)
> > {
> > - unsigned long msecs;
> > + unsigned int msecs;
> > int err;
> >
> > - err = kstrtoul(buf, 10, &msecs);
> > - if (err || msecs > UINT_MAX)
> > + err = kstrtouint(buf, 10, &msecs);
> > + if (err)
> > return -EINVAL;
> >
> > ksm_stable_node_chains_prune_millisecs = msecs;
>
> LGTM, but I would merge the two patches together. They both update
> types of sysfs tunnables in the same file.
Ok, I'll send v2 as a single patch.
Thanks,
Zhansaya
prev parent reply other threads:[~2021-07-16 4:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 18:00 [PATCH 0/2] mm: KSM: fix data types Zhansaya Bagdauletkyzy
2021-07-15 18:01 ` [PATCH 1/2] mm: KSM: fix ksm_run data type Zhansaya Bagdauletkyzy
2021-07-15 18:10 ` Pavel Tatashin
2021-07-15 18:17 ` Matthew Wilcox
2021-07-15 18:21 ` Pavel Tatashin
2021-07-15 18:30 ` Matthew Wilcox
2021-07-15 18:57 ` Pavel Tatashin
2021-07-15 19:06 ` Pavel Tatashin
2021-07-15 18:01 ` [PATCH 2/2] mm: KSM: fix " Zhansaya Bagdauletkyzy
2021-07-15 18:10 ` Pavel Tatashin
2021-07-16 4:42 ` Zhansaya Bagdauletkyzy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716044201.GA210515@asus \
--to=zhansayabagdaulet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=tyhicks@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).