From: Matthew Wilcox <willy@infradead.org>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tyler Hicks <tyhicks@linux.microsoft.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mm: KSM: fix ksm_run data type
Date: Thu, 15 Jul 2021 19:30:13 +0100 [thread overview]
Message-ID: <YPB+tT0AcOB4UZQ5@casper.infradead.org> (raw)
In-Reply-To: <CA+CK2bCPMmbr+=h4evTkbJoEFQu_th_NOe0Gp11hU7xz3fLZ8A@mail.gmail.com>
On Thu, Jul 15, 2021 at 02:21:21PM -0400, Pavel Tatashin wrote:
> On Thu, Jul 15, 2021 at 2:18 PM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Fri, Jul 16, 2021 at 12:01:01AM +0600, Zhansaya Bagdauletkyzy wrote:
> > > +++ b/mm/ksm.c
> > > @@ -289,7 +289,7 @@ static int ksm_nr_node_ids = 1;
> > > #define KSM_RUN_MERGE 1
> > > #define KSM_RUN_UNMERGE 2
> > > #define KSM_RUN_OFFLINE 4
> > > -static unsigned long ksm_run = KSM_RUN_STOP;
> > > +static unsigned int ksm_run = KSM_RUN_STOP;
> >
> > Should this be an enum instead?
>
> I think "unsigned int" is OK here, as it is exposed as uint to users:
> Documentation/ABI/testing/sysfs-kernel-mm-ksm
>
> /sys/kernel/mm/ksm/run
>
> run: write 0 to disable ksm, read 0 while ksm is disabled.
>
> - write 1 to run ksm, read 1 while ksm is running.
> - write 2 to disable ksm and unmerge all its pages.
The document is out of date then as it does not mention 'offline'.
Also, why does the call to kstrtouint() specify base 10? If it is a
bitmap, then permitting 0x [1] is more natural. I would expect to see
base 0 there.
[1] or even 0b, although I see that _parse_integer_fixup_radix does not
support the 0b notation.
next prev parent reply other threads:[~2021-07-15 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 18:00 [PATCH 0/2] mm: KSM: fix data types Zhansaya Bagdauletkyzy
2021-07-15 18:01 ` [PATCH 1/2] mm: KSM: fix ksm_run data type Zhansaya Bagdauletkyzy
2021-07-15 18:10 ` Pavel Tatashin
2021-07-15 18:17 ` Matthew Wilcox
2021-07-15 18:21 ` Pavel Tatashin
2021-07-15 18:30 ` Matthew Wilcox [this message]
2021-07-15 18:57 ` Pavel Tatashin
2021-07-15 19:06 ` Pavel Tatashin
2021-07-15 18:01 ` [PATCH 2/2] mm: KSM: fix " Zhansaya Bagdauletkyzy
2021-07-15 18:10 ` Pavel Tatashin
2021-07-16 4:42 ` Zhansaya Bagdauletkyzy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPB+tT0AcOB4UZQ5@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=tyhicks@linux.microsoft.com \
--cc=zhansayabagdaulet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).