From: Steven Rostedt <rostedt@goodmis.org>
To: David Hildenbrand <david@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, ebiederm@xmission.com,
willy@infradead.org, linux-nfs@vger.kernel.org,
viro@zeniv.linux.org.uk, linux-doc@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
akpm@linux-foundation.org, luto@kernel.org, bfields@fieldses.org,
w@1wt.eu, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks
Date: Fri, 20 Aug 2021 12:08:48 -0400 [thread overview]
Message-ID: <20210820120848.5692d25a@oasis.local.home> (raw)
In-Reply-To: <0f4f3e65-1d2d-e512-2a6f-d7d63effc479@redhat.com>
On Fri, 20 Aug 2021 17:52:19 +0200
David Hildenbrand <david@redhat.com> wrote:
> > +static bool warned_mand;
> > static inline bool may_mandlock(void)
> > {
> > + if (!warned_mand) {
> > + warned_mand = true;
> > + pr_warn("======================================================\n");
> > + pr_warn("WARNING: the mand mount option is being deprecated and\n");
> > + pr_warn(" will be removed in v5.15!\n");
> > + pr_warn("======================================================\n");
> > + }
>
> Is there a reason not to use pr_warn_once() ?
You would need a single call though, otherwise each pr_warn_once()
would have its own state that it warned once.
const char warning[] =
"======================================================\n"
"WARNING: the mand mount option is being deprecated and\n"
" will be removed in v5.15!\n"
"======================================================\n";
pr_warn_once(warning);
-- Steve
next prev parent reply other threads:[~2021-08-20 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 13:57 [PATCH v2 0/2] fs: remove support for mandatory locking Jeff Layton
2021-08-20 13:57 ` [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Jeff Layton
2021-08-20 15:49 ` David Laight
2021-08-20 15:50 ` Jeff Layton
2021-08-20 15:52 ` David Hildenbrand
2021-08-20 16:06 ` Jeff Layton
2021-08-20 16:08 ` Steven Rostedt [this message]
2021-08-20 13:57 ` [PATCH v2 2/2] fs: remove mandatory file locking support Jeff Layton
2021-08-20 14:09 ` [PATCH v2 0/2] fs: remove support for mandatory locking J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820120848.5692d25a@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=cluster-devel@redhat.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=w@1wt.eu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).