From: David Laight <David.Laight@ACULAB.COM>
To: 'Jeff Layton' <jlayton@kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "ebiederm@xmission.com" <ebiederm@xmission.com>,
"david@redhat.com" <david@redhat.com>,
"willy@infradead.org" <willy@infradead.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"v9fs-developer@lists.sourceforge.net"
<v9fs-developer@lists.sourceforge.net>,
"linux-afs@lists.infradead.org" <linux-afs@lists.infradead.org>,
"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"luto@kernel.org" <luto@kernel.org>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"w@1wt.eu" <w@1wt.eu>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks
Date: Fri, 20 Aug 2021 15:49:22 +0000 [thread overview]
Message-ID: <c1318459eaab436aacb225982c49c4b4@AcuMS.aculab.com> (raw)
In-Reply-To: <20210820135707.171001-2-jlayton@kernel.org>
From: Jeff Layton
> Sent: 20 August 2021 14:57
>
> We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros
> have disabled it. Warn the stragglers that still use "-o mand" that
> we'll be dropping support for that mount option.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/namespace.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index ab4174a3c802..ffab0bb1e649 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1716,8 +1716,16 @@ static inline bool may_mount(void)
> }
>
> #ifdef CONFIG_MANDATORY_FILE_LOCKING
> +static bool warned_mand;
> static inline bool may_mandlock(void)
> {
> + if (!warned_mand) {
> + warned_mand = true;
> + pr_warn("======================================================\n");
> + pr_warn("WARNING: the mand mount option is being deprecated and\n");
> + pr_warn(" will be removed in v5.15!\n");
> + pr_warn("======================================================\n");
> + }
> return capable(CAP_SYS_ADMIN);
> }
If that is called more than once you don't want the 'inline'.
I doubt it matters is not inlined - hardly a hot path.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-08-20 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 13:57 [PATCH v2 0/2] fs: remove support for mandatory locking Jeff Layton
2021-08-20 13:57 ` [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Jeff Layton
2021-08-20 15:49 ` David Laight [this message]
2021-08-20 15:50 ` Jeff Layton
2021-08-20 15:52 ` David Hildenbrand
2021-08-20 16:06 ` Jeff Layton
2021-08-20 16:08 ` Steven Rostedt
2021-08-20 13:57 ` [PATCH v2 2/2] fs: remove mandatory file locking support Jeff Layton
2021-08-20 14:09 ` [PATCH v2 0/2] fs: remove support for mandatory locking J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1318459eaab436aacb225982c49c4b4@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=cluster-devel@redhat.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=w@1wt.eu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).